Re: svn commit: r1632450 - /subversion/trunk/subversion/svnfsfs/stats-cmd.c

[Ivan Zhakov <iv...@visualsvn.com>]

On 17 October 2014 03:13,  <st...@apache.org> wrote:
> Author: stefan2
> Date: Fri Oct 17 00:13:49 2014
> New Revision: 1632450
>
> URL: http://svn.apache.org/r1632450
> Log:
> Prepare 'svnfsfs stats' code to be split into a logic part within FSFS,
> a UI bit in svnfsfs and an FSFS-private interface in between them.
>
> This patch moves all stats information from the fs_t struct and function
> locals into a separate svn_fs_fs__stats_t struct.  All field types in that
> struct are renamed to svn_fs_fs__*.  No code is being moved outside the
> original file, yet.
>
It seems that svn_fs_fs_* stats API structures uses apr_size_t for
file sizes and offsets, instead of apr_off_t or apr_int64_t:
svn_fs_fs__large_change_info_t.size,  rep_stats_t.offset,
rep_stats_t.size, rep_stats_t.expanded_size and etc.

This makes svnfsfs stats tool fail for repositories with >2GB
revisions on 32bit platforms.

-- 
Ivan Zhakov

Re: svn commit: r1632450 - /subversion/trunk/subversion/svnfsfs/stats-cmd.c

[Stefan Fuhrmann <st...@wandisco.com>]

On Fri, Nov 7, 2014 at 1:33 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:

> On 17 October 2014 03:13,  <st...@apache.org> wrote:
> > Author: stefan2
> > Date: Fri Oct 17 00:13:49 2014
> > New Revision: 1632450
> >
> > URL: http://svn.apache.org/r1632450
> > Log:
> > Prepare 'svnfsfs stats' code to be split into a logic part within FSFS,
> > a UI bit in svnfsfs and an FSFS-private interface in between them.
> >
> > This patch moves all stats information from the fs_t struct and function
> > locals into a separate svn_fs_fs__stats_t struct.  All field types in
> that
> > struct are renamed to svn_fs_fs__*.  No code is being moved outside the
> > original file, yet.
> >
> It seems that svn_fs_fs_* stats API structures uses apr_size_t for
> file sizes and offsets, instead of apr_off_t or apr_int64_t:
> svn_fs_fs__large_change_info_t.size,  rep_stats_t.offset,
> rep_stats_t.size, rep_stats_t.expanded_size and etc.
>
> This makes svnfsfs stats tool fail for repositories with >2GB
> revisions on 32bit platforms.
>

Yes, that is a restriction carried over from 1.8. As of r1639355,
phys. addressed revisions may have arbitrary lengths as well.

-- Stefan^2.