You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Pankraz76 (via GitHub)" <gi...@apache.org> on 2025/05/11 10:35:09 UTC

[PR] JUnit Jupiter best practices [maven]

Pankraz76 opened a new pull request, #2320:
URL: https://github.com/apache/maven/pull/2320

   - https://docs.openrewrite.org/recipes/java/testing/junit5/junit5bestpractices
   - 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [POC] JUnit Jupiter best practices [maven]

Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #2320:
URL: https://github.com/apache/maven/pull/2320#issuecomment-2876446335

   FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [POC] JUnit Jupiter best practices [maven]

Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #2320:
URL: https://github.com/apache/maven/pull/2320#issuecomment-2876038573

   > I strongly prefer to prefix method names with "test". method names are verbs that describe what the method does. That's the best practice to follow. A method that tests foo should be named testFoo, not foo.
   
   being outdated is no problem, it will catch us all. Its only a problem when not evolving therefore leaving being risking being obsolet.
   
   <img width="961" alt="image" src="https://github.com/user-attachments/assets/06742b29-e814-46f1-9a3c-ff6137f43c5b" />
   
   - https://junit.org/junit5/docs/current/user-guide/#writing-tests-parallel-execution-synchronization
   - https://thejavaguy.org/posts/011-dont-prefix-junit-tests-with-the-word-test/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [POC] JUnit Jupiter best practices [maven]

Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 closed pull request #2320: [POC] JUnit Jupiter best practices
URL: https://github.com/apache/maven/pull/2320


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [POC] JUnit Jupiter best practices [maven]

Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #2320:
URL: https://github.com/apache/maven/pull/2320#issuecomment-2876045623

   principle here might be [DRY](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself)
   
   as first thing we read is trash just like the null checks 
   
   very first attention already going into void. Thats bad design. We tend to apply functional style, reducing everything. Then we are left over with only real business logic and not fluff.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [POC] JUnit Jupiter best practices [maven]

Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #2320:
URL: https://github.com/apache/maven/pull/2320#issuecomment-2875410600

   yes everyone has some opinion.
   Thats the reason for best practice, not having to discuss every detail over and over again.
   
   This idea(l) is known as https://en.wikipedia.org/wiki/Convention_over_configuration
   
   As the whole world is probably following, its hart to outsmart them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org