You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by holdenk <gi...@git.apache.org> on 2017/12/22 06:17:49 UTC

[GitHub] spark pull request #19876: [ML][SPARK-11171][SPARK-11239] Add PMML export to...

Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19876#discussion_r158434850
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
    @@ -554,7 +555,49 @@ class LinearRegressionModel private[ml] (
        * This also does not save the [[parent]] currently.
        */
       @Since("1.6.0")
    -  override def write: MLWriter = new LinearRegressionModel.LinearRegressionModelWriter(this)
    +  override def write: GeneralMLWriter = new GeneralMLWriter(this)
    --- End diff --
    
    fixed


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org