[jira] Commented: (LUCENE-1722) SmartChineseAnalyzer javadoc improvement

["Simon Willnauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725657#action_12725657 ] 

Simon Willnauer commented on LUCENE-1722:
-----------------------------------------

Robert, I had a look at this patch - good work! 

Are you planing to add more javadoc fixes to it, I found a couple of inline comment being still chinese in
BigramDictionary.java
BiSegGraph.java
HHMMSegmenter.java

and real javadoc in 
WordDictionary.java

I also think we could remove the commented source code in 
SegToken.java
SegTokenPair.java

as well as the logger code in 
WordDictionary.java

simon

> SmartChineseAnalyzer javadoc improvement
> ----------------------------------------
>
>                 Key: LUCENE-1722
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1722
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>            Reporter: Robert Muir
>            Assignee: Simon Willnauer
>            Priority: Minor
>         Attachments: LUCENE-1722.txt
>
>
> Chinese -> English, and corrections to match reality (removes several javadoc warnings)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org