[jira] [Commented] (SOLR-16694) Shortcut Http2SolrClient mimeType check for default response parse

["Tomas Eduardo Fernandez Lobbe (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-16694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698683#comment-17698683 ] 

Tomas Eduardo Fernandez Lobbe commented on SOLR-16694:
------------------------------------------------------

I ran the benchmark in [the PR|https://github.com/apache/solr/pull/1447], saw minor improvements (from 0.4% to 2.1% in different runs). The flame graph shows the difference:
Main:
 !screenshot-1.png! 
Patch:
 !screenshot-2.png! 

> Shortcut Http2SolrClient mimeType check for default response parse
> ------------------------------------------------------------------
>
>                 Key: SOLR-16694
>                 URL: https://issues.apache.org/jira/browse/SOLR-16694
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Tomas Eduardo Fernandez Lobbe
>            Priority: Minor
>         Attachments: screenshot-1.png, screenshot-2.png
>
>
> Http2SolrClient has some logic to get the list of content types supported by the response parser, parse those from String into {{ContentType}} objects to then get the mimeType of those and put them on a Set, to later check against the response content type. 
> In practice, most users of Http2SolrClient (including Solr itself) will be using javabin with the BinaryResponseParser, for which we know the exact mimeType that will accept. We could avoid the logic I've described above for cases where the response parser is the default one
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org