You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "philipnee (via GitHub)" <gi...@apache.org> on 2024/06/02 20:15:46 UTC

Re: [PR] KAFKA-16558 Implemented HeartbeatRequestState toStringBase() and added a test for it [kafka]

philipnee commented on code in PR #16124:
URL: https://github.com/apache/kafka/pull/16124#discussion_r1623645864


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -452,7 +452,7 @@ private void handleFatalFailure(Throwable error) {
      * object extends {@link RequestState} to enable exponential backoff and duplicated request handling. The two fields
      * that it holds are:
      */
-    static class HeartbeatRequestState extends RequestState {
+    protected static class HeartbeatRequestState extends RequestState {

Review Comment:
   this is for testing purpose right? add a // Visible for testing comment 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org