You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by bu...@apache.org on 2002/04/24 21:34:43 UTC

DO NOT REPLY [Bug 8488] New: - Serializable issues in Tiles

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8488>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8488

Serializable issues in Tiles

           Summary: Serializable issues in Tiles
           Product: Struts
           Version: Nightly Build
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Utilities
        AssignedTo: struts-dev@jakarta.apache.org
        ReportedBy: beskrowni@alumni.cmu.edu


I18nFactorySet implements Serializable, but contains some attributes that don't:

protected DefinitionsFactory defaultFactory;
protected XmlParser xmlParser;

Since these unserializable attributes exist in a Serializable object, we get a 
java.io.NotSerializableException when running in WLS 6.1 sp1

We solved this problem on our local build by having DefinitionsFactory 
implement Serializable and by making the XmlParser attribute transient.  a log 
of our changes is included below:

================================================

--- 
contrib/tiles/src/share/org/apache/struts/tiles/xmlDefinition/DefinitionsFactory
.java	24 Apr 2002 18:45:58 -0000
***************
*** 8,13 ****
--- 8,14 ----
  import org.apache.struts.tiles.FactoryNotFoundException;
  import org.apache.struts.tiles.NoSuchDefinitionException;
  
+ import java.io.Serializable;
  import java.util.Map;
  import java.util.HashMap;
  import java.util.Iterator;
***************
*** 21,27 ****
   * A factory for definitions.
   * This factory allows to retrieve definitions by their keys.
   */
! public class DefinitionsFactory
  {
       /** */
     protected Map definitions;
--- 22,28 ----
   * A factory for definitions.
   * This factory allows to retrieve definitions by their keys.
   */
! public class DefinitionsFactory implements Serializable
  {
       /** */
     protected Map definitions;
Index: 
contrib/tiles/src/share/org/apache/struts/tiles/xmlDefinition/I18nFactorySet.jav
a
===================================================================
RCS file: /home/cvspublic/jakarta-
struts/contrib/tiles/src/share/org/apache/struts/tiles/xmlDefinition/I18nFactory
Set.java,v
retrieving revision 1.4
diff -b -c -r1.4 I18nFactorySet.java
***  
contrib/tiles/src/share/org/apache/struts/tiles/xmlDefinition/I18nFactorySet.jav
a	24 Apr 2002 18:45:58 -0000
***************
*** 62,68 ****
      /** Default factory */
    protected DefinitionsFactory defaultFactory;
      /** Xml parser used */
!   protected XmlParser xmlParser;
      /** Does we want validating parser ? Default is false.
       *  Can be set from servlet config file
       */
--- 62,68 ----
      /** Default factory */
    protected DefinitionsFactory defaultFactory;
      /** Xml parser used */
!   protected transient XmlParser xmlParser;
      /** Does we want validating parser ? Default is false.
       *  Can be set from servlet config file
       */

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: 16 or 21st

Posted by Vic Cekvenich <vi...@basebeans.com>.
Please resend message.
Vic

Dan Sykes - General Manager (US) wrote:

> DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
> RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
> <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8488>.
> ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
> INSERTED IN THE BUG DATABASE.
> 
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8488
> 
> Serializable issues in Tiles
> 
>            Summary: Serializable issues in Tiles
>            Product: Struts
>            Version: Nightly Build
>           Platform: Other
>         OS/Version: Other
>             Status: NEW
>           Severity: Normal
>           Priority: Other
>          Component: Utilities
>         AssignedTo: struts-dev@jakarta.apache.org
>         ReportedBy: beskrowni@alumni.cmu.edu
> 
> 
> I18nFactorySet implements Serializable, but contains some attributes that don't:
> 
> protected DefinitionsFactory defaultFactory;
> protected XmlParser xmlParser;
> 
> Since these unserializable attributes exist in a Serializable object, we get a 
> java.io.NotSerializableException when running in WLS 6.1 sp1
> 
> We solved this problem on our local build by having DefinitionsFactory 
> implement Serializable and by making the XmlParser attribute transient.  a log 
> of our changes is included below:
> 
> ================================================
> 
> --- 
> contrib/tiles/src/share/org/apache/struts/tiles/xmlDefinition/DefinitionsFactory
> .java	24 Apr 2002 18:45:58 -0000
> ***************
> *** 8,13 ****
> --- 8,14 ----
>   import org.apache.struts.tiles.FactoryNotFoundException;
>   import org.apache.struts.tiles.NoSuchDefinitionException;
>   
> + import java.io.Serializable;
>   import java.util.Map;
>   import java.util.HashMap;
>   import java.util.Iterator;
> ***************
> *** 21,27 ****
>    * A factory for definitions.
>    * This factory allows to retrieve definitions by their keys.
>    */
> ! public class DefinitionsFactory
>   {
>        /** */
>      protected Map definitions;
> --- 22,28 ----
>    * A factory for definitions.
>    * This factory allows to retrieve definitions by their keys.
>    */
> ! public class DefinitionsFactory implements Serializable
>   {
>        /** */
>      protected Map definitions;
> Index: 
> contrib/tiles/src/share/org/apache/struts/tiles/xmlDefinition/I18nFactorySet.jav
> a
> ===================================================================
> RCS file: /home/cvspublic/jakarta-
> struts/contrib/tiles/src/share/org/apache/struts/tiles/xmlDefinition/I18nFactory
> Set.java,v
> retrieving revision 1.4
> diff -b -c -r1.4 I18nFactorySet.java
> ***  
> contrib/tiles/src/share/org/apache/struts/tiles/xmlDefinition/I18nFactorySet.jav
> a	24 Apr 2002 18:45:58 -0000
> ***************
> *** 62,68 ****
>       /** Default factory */
>     protected DefinitionsFactory defaultFactory;
>       /** Xml parser used */
> !   protected XmlParser xmlParser;
>       /** Does we want validating parser ? Default is false.
>        *  Can be set from servlet config file
>        */
> --- 62,68 ----
>       /** Default factory */
>     protected DefinitionsFactory defaultFactory;
>       /** Xml parser used */
> !   protected transient XmlParser xmlParser;
>       /** Does w
> 



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>