You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by jd...@apache.org on 2025/05/29 19:14:45 UTC

(grails-core) branch 7.0.x updated (af66c2d448 -> f357fa209b)

This is an automated email from the ASF dual-hosted git repository.

jdaugherty pushed a change to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/grails-core.git


    from af66c2d448 [skip ci] troubleshooting svn connection
     new a04a262c3e [skip ci] update RELEASE.md
     new 821b9e28c1 [skip ci] generate sha512 for wrapper zip
     new 5aed4b28bf [skip ci] add checksum for source zip
     new f357fa209b [skip ci] upload sha512 checksums

The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .github/workflows/release-source-distribution.yml |  10 +-
 .github/workflows/release-upload.yml              |   3 +
 .github/workflows/release.yml                     |   4 +
 RELEASE.md                                        | 109 +++++++++++++++++-----
 4 files changed, 102 insertions(+), 24 deletions(-)


(grails-core) 01/04: [skip ci] update RELEASE.md

Posted by jd...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

jdaugherty pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/grails-core.git

commit a04a262c3e6d9031f69b6361a479c7aa145c989b
Author: James Daugherty <jd...@jdresources.net>
AuthorDate: Thu May 29 15:10:01 2025 -0400

    [skip ci] update RELEASE.md
---
 RELEASE.md | 109 ++++++++++++++++++++++++++++++++++++++++++++++++-------------
 1 file changed, 86 insertions(+), 23 deletions(-)

diff --git a/RELEASE.md b/RELEASE.md
index 187bdee01e..06786b5137 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -47,53 +47,104 @@ During the staging step, we must create a source distribution & stage any binary
 3. Create a matching release in `grails-forge`:
    * Follow the same steps to create a release in grails-forge. Update any release notes specific to the delegating cli & grails forge.
 4. (grails-forge) The Github workflow `release.yml`, titled `Release - Create grails-forge`, will kick off.  This workflow will run a `publish` job that will complete similar steps to the `grails-core` publish job.
-5. Kick off the `Release - Grails Distribution` workflow from `distribution.yml` in `grails-core`. This job will: 
+5. Kick off the `Release - Source Distribution` workflow from `release-source-distribution.yml` in `grails-core`. This job will: 
      * download the tagged grails source
      * download the tagged grails-forge source
      * generate a source distribution meeting the ASF requirements
-     * upload the source distribution to the Github release `grails-core` release
+     * upload the source distribution to the Github `grails-core` release
+6. Kick off the `Release - Upload to dist.apache.org` workflow from `release-upload.yml` in `grails-core`. This job will:
+     * update the KEYS file under https://dist.apache.org/repos/dist/release/grails/KEYS with the version in the tagged source code
      * upload the source distribution to https://dist.apache.org/repos/dist/dev/grails/VERSION/sources
-6. Kick off the `Distribution` workflow in `grails-forge`, which will:
-     * create a binary distribution of the grails CLIs
-     * upload the binary distribution to the Github release `grails-forge` release
-     * upload the binary distribution that will be uploaded to sdkman to https://dist.apache.org/repos/dist/dev/grails/VERSION/distribution
+     * upload the grails-wrapper binary distribution to https://dist.apache.org/repos/dist/dev/grails/VERSION/distribution
+     * upload the grails binary distribution to https://dist.apache.org/repos/dist/dev/grails/VERSION/distribution (note: this is the sdkman artifact)
 
 Once `grails-forge` & `grails-core` are published the end source & binary distributions should be staged. 
 
 ## 2. Verifying
 
-Prior to releasing a vote, we need to verify the staged artifacts. At a high level, the following must be completed to verify these artifacts:
-1. Download the zipped source distribution artifacts:
+Prior to releasing a vote, we need to verify the staged artifacts. Follow the below steps to verify each staged artifact.
+
+### Source Distribution Verification
+Download the zipped source distribution artifacts:
    * `apache-grails-<version>-incubating-src.zip` - the source distribution
    * `apache-grails-<version>-incubating-src.zip.asc` - the public key to verify the source distribution
    * `apache-grails-<version>-incubating-src.zip.sha512` - the checksum to verify the source distribution
-2. Verify the distribution checksum via the command:
+
+from [https://dist.apache.org/repos/dist/dev/grails/version](https://dist.apache.org/repos/dist/dev/grails)
+
+Verify the source distribution checksum via the command:
    ```bash
    shasum -a 512 -c apache-grails-<version>-incubating-src.zip.sha512
    ```
-3. Verify the distribution signature via the command:
+
+Verify the source distribution signature via the command:
    ```bash
     gpg --verify apache-grails-<version>-incubating-src.zip.asc apache-grails-<version>-incubating-src.zip
-    ```
-4. Extract the zip file and verify the contents:
+   ```
+
+Extract the zip file and verify the contents:
    * Ensure the `LICENSE` & `NOTICE` files are present to ensure license compliance.
    * Ensure `README.md` & `CONTRIBUTING.md` are present to ensure project build & usage instructions are present.
    * Ensure the `PUBLISHED` file is present so we know how to pull the various jar files.
-5. Verify the signed jar files by downloading all jars inside of the `PUBLISHED` file.
-   * For each jar, verify the jar file matches the published one:
-   ```bash
-    gpg --verify <jar>.asc <jar>
+
+### Jar file Signature Verification (Nexus Staging Repositories)
+As part of uploading to repository.apache.org the signatures are verified to match a KEY that has been distributed.  It does not verify that the jar files are built with a key trusted by the Grails project.
+
+Download the latest KEYS file and make sure it's imported into gpg:
+```bash
+    wget https://github.com/apache/grails-core/blob/7.0.x/KEYS
+    gpg --import KEYS
+```
+
+The jar files will need downloaded and verified they were signed by a valid Grails key.  Run the script (substitute the staging repo name):  
+```bash
+    wget --recursive --no-parent --accept jar,asc https://repository.apache.org/content/repositories/orgapachegrails-1020/org/apache/grails
+    for jar_file in *.jar; do
+      asc_file="${jar_file}.asc"
+    
+      if [[ -f "$asc_file" ]]; then
+        echo "🔍 Verifying $jar_file..."
+    
+        gpg --verify "$asc_file" "$jar_file"
+        verify_status=$?
+    
+        if [ $verify_status -eq 0 ]; then
+          echo "✅ $jar_file is correctly signed."
+        else
+          echo "❌ $jar_file FAILED signature verification!"
+        fi
+    
+        echo ""
+      else
+        echo "⚠️ No .asc file found for $jar_file. Skipping."
+      fi
+    done
+```
+
+### Reproducible Jar File
+After all jar files are verified to be signed by a valid Grails key, we need to build a local copy to ensure the file was built with the right code base.
+
+Bootstrap the source distribution so that it can be built: 
+    ```bash
+    gradle wrapper
     ```
-6. Run the `verify-distribution.sh` shell script to compare the published jar files to a locally built version of them.
-7. For any differences, extract the jar files, use IntelliJ to compare each differing file. Assuming differences are ordering related, we can continue with the verification.
-8. Download the binary distrubtion & expand it to test the various CLI's: `grailsw` (wrapper), `grails` (delegating), `grails-forge-cli`, and `grails-shell-cli`.  For each CLI, verify the published signature in the `PUBLISHED` file:
+
+Run the `verify-distribution.sh` shell script to compare the published jar files to a locally built version of them. For any differences, extract the jar files, use IntelliJ to compare each differing file. Assuming differences are ordering related, we can continue with the verification.
+
+### Binary Distribution Verification
+Download the binary distribution & expand it to test the various CLI's: `grailsw` (wrapper), `grails` (delegating), `grails-forge-cli`, and `grails-shell-cli`.  For each CLI, verify the published signature in the `PUBLISHED` file:
    ```bash
     gpg --verify <cli>.asc <cli>
    ```
-10. testing `grailsw`:
+
+### CLI Testing
+
+Each CLI needs tested to ensure it's functional prior to release:
+
+* testing `grailsw`:
     * set GRAILS_REPO_URL to the staging repository
     * run `grailsw` and ensure it downloads the correct jars to `.grails` (verify the checksums of the jars)
-11. testing `grails-shell-cli`:
+* testing `grails-shell-cli`:
     * create a basic app:
     ```bash
     grails-shell-cli create-app test
@@ -103,7 +154,7 @@ Prior to releasing a vote, we need to verify the staged artifacts. At a high lev
     ```bash
     grails-shell-cli run-app
     ```
-12. Perform the same tests, but use the delegating cli `grails` with type forge
+* Perform the same tests, but use the delegating cli `grails` with type forge
     * create a basic app:
     ```bash
     grails -t forge create-app test
@@ -119,6 +170,18 @@ Prior to releasing a vote, we need to verify the staged artifacts. At a high lev
 
 TODO
 
-## 3. Releasing
+## 4. Releasing
 
 TODO
+
+# Rollback
+
+In the event a staged artifact needs rolled back, follow the below steps:
+
+## Rollback Nexus Artifacts (Jars)
+
+To remove a Nexus staging repo, run the workflow `Release - Drop Nexus Staging` in `grails-core`.  The input of this task can be obtained by logging into [repository.apache.org](https://repository.apache.org/index.html#stagingRepositories) and finding the staging repository name. Please note that there will always be 2 staging repositories for a Grails release because we keep `grails-forge` separate from `grails-core`.
+
+## Rollback Distribution
+
+To remove the staged distribution, use your SVN credentials to remove the version directory at [https://dist.apache.org/repos/dist/dev/grails](https://dist.apache.org/repos/dist/dev/grails)
\ No newline at end of file


(grails-core) 03/04: [skip ci] add checksum for source zip

Posted by jd...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

jdaugherty pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/grails-core.git

commit 5aed4b28bf3dfce495104f739b311c2c9be58531
Author: James Daugherty <jd...@jdresources.net>
AuthorDate: Thu May 29 15:14:05 2025 -0400

    [skip ci] add checksum for source zip
---
 .github/workflows/release-source-distribution.yml | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/release-source-distribution.yml b/.github/workflows/release-source-distribution.yml
index ff56c0e713..7ff652177a 100644
--- a/.github/workflows/release-source-distribution.yml
+++ b/.github/workflows/release-source-distribution.yml
@@ -66,11 +66,19 @@ jobs:
         env:
           GPG_KEY_ID: ${{ secrets.GPG_KEY_ID }}
         run: |
-          gpg --default-key "${GPG_KEY_ID}" --batch --yes --pinentry-mode loopback --armor --detach-sign apache-grails-*-incubating-src.zip
+          version="${{ github.ref_name }}"
+          version="${version#v}"  # Strip 'v' prefix
+          gpg --default-key "${GPG_KEY_ID}" --batch --yes --pinentry-mode loopback --armor --detach-sign apache-grails-${version}-incubating-src.zip
+      - name: "📦 Create source distribution checksum"
+        run: |
+          version="${{ github.ref_name }}"
+          version="${version#v}"  # Strip 'v' prefix
+          sha512sum apache-grails-${version}-incubating-src.zip | awk '{print $1}' > "grails-wrapper/build/distributions/apache-grails-${version}-incubating-src.zip.sha512"
       - name: "🚀 Upload ZIP and Signature to GitHub Release"
         uses: softprops/action-gh-release@v2
         with:
           tag_name: ${{ github.ref_name }}
           files: |
             apache-grails-*-incubating-src.zip
+            apache-grails-*-incubating-src.zip.sha512
             apache-grails-*-incubating-src.zip.asc


(grails-core) 04/04: [skip ci] upload sha512 checksums

Posted by jd...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

jdaugherty pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/grails-core.git

commit f357fa209b27bac1cf978bf164214ff95ba2c656
Author: James Daugherty <jd...@jdresources.net>
AuthorDate: Thu May 29 15:14:35 2025 -0400

    [skip ci] upload sha512 checksums
---
 .github/workflows/release-upload.yml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.github/workflows/release-upload.yml b/.github/workflows/release-upload.yml
index 07eddbc128..48fa7e6311 100644
--- a/.github/workflows/release-upload.yml
+++ b/.github/workflows/release-upload.yml
@@ -105,6 +105,7 @@ jobs:
           mkdir -p $VERSION/source          
           cd $VERSION/source
           curl -LO https://github.com/apache/grails-core/releases/download/$TAG/apache-grails-$VERSION-incubating-src.zip
+          curl -LO https://github.com/apache/grails-core/releases/download/$TAG/apache-grails-$VERSION-incubating-src.zip.sha512
           curl -LO https://github.com/apache/grails-core/releases/download/$TAG/apache-grails-$VERSION-incubating-src.zip.asc
           echo "Adding the following files:"
           ls -l
@@ -119,6 +120,7 @@ jobs:
           mkdir -p $VERSION/distribution
           cd $VERSION/distribution
           curl -LO https://github.com/apache/grails-forge/releases/download/$TAG/apache-grails-$VERSION-incubating-bin.zip
+          curl -LO https://github.com/apache/grails-forge/releases/download/$TAG/apache-grails-$VERSION-incubating-bin.zip.sha512
           curl -LO https://github.com/apache/grails-forge/releases/download/$TAG/apache-grails-$VERSION-incubating-bin.zip.asc
           echo "Adding the following files:"
           ls -l
@@ -131,6 +133,7 @@ jobs:
           VERSION=${{ steps.release_version.outputs.version }}
           cd dev-repo/$VERSION/distribution
           curl -LO https://github.com/apache/grails-core/releases/download/$TAG/apache-grails-wrapper-$VERSION-incubating-bin.zip
+          curl -LO https://github.com/apache/grails-core/releases/download/$TAG/apache-grails-wrapper-$VERSION-incubating-bin.zip.sha512
           curl -LO https://github.com/apache/grails-core/releases/download/$TAG/apache-grails-wrapper-$VERSION-incubating-bin.zip.asc
           echo "Adding the following files:"
           ls -l


(grails-core) 02/04: [skip ci] generate sha512 for wrapper zip

Posted by jd...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

jdaugherty pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/grails-core.git

commit 821b9e28c1b25ea7c698b070d3b9de1e1fa5be6f
Author: James Daugherty <jd...@jdresources.net>
AuthorDate: Thu May 29 15:11:51 2025 -0400

    [skip ci] generate sha512 for wrapper zip
---
 .github/workflows/release.yml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 72f3c68b65..65faffb978 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -75,11 +75,15 @@ jobs:
           GPG_KEY_ID: ${{ secrets.GPG_KEY_ID }}
         run: |
           gpg --default-key "${GPG_KEY_ID}" --batch --yes --pinentry-mode loopback --armor --detach-sign grails-wrapper/build/distributions/apache-grails-wrapper-${{ steps.release_version.outputs.value }}-incubating-bin.zip
+      - name: "📦 Create wrapper checksum"
+        run: |
+          sha512sum grails-wrapper/build/distributions/apache-grails-wrapper-${{ steps.release_version.outputs.value }}-incubating-bin.zip | awk '{print $1}' > "grails-wrapper/build/distributions/apache-grails-wrapper-${{ steps.release_version.outputs.value }}-incubating-bin.zip.sha512"
       - name: "📤 Upload grails wrapper ZIP"
         uses: softprops/action-gh-release@v2
         with:
           files: |
             grails-wrapper/build/distributions/apache-grails-wrapper-${{ steps.release_version.outputs.value }}-incubating-bin.zip
+            grails-wrapper/build/distributions/apache-grails-wrapper-${{ steps.release_version.outputs.value }}-incubating-bin.zip.sha512
             grails-wrapper/build/distributions/apache-grails-wrapper-${{ steps.release_version.outputs.value }}-incubating-bin.zip.asc
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}