You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "charliec05 (via GitHub)" <gi...@apache.org> on 2026/08/19 06:40:32 UTC
[PR] Spark: Fix map value decoding in test helpers [iceberg]
charliec05 opened a new pull request, #17721:
URL: https://github.com/apache/iceberg/pull/17721
## Description
The Spark test helpers decoded both map keys and values using the map key type. This updates `GenericsHelpers` and `TestHelpers` for Spark 3.5, 4.0, and 4.1 to decode map values using the value type, so comparisons remain correct when key and value types differ.
Closes #17717.
## Testing
- `TestSparkAvroReader.testNumericMapKey` for Spark 3.5, 4.0, and 4.1
- `./gradlew -DsparkVersions=3.5,4.0,4.1 spotlessCheck`
## AI Disclosure
- Model: GPT-5
- Platform/Tool: Codex
- Human Oversight: unreviewed
- Prompt Summary: Find a small Apache Iceberg contribution, implement and test the fix, and open a pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark: Fix map value decoding in test helpers [iceberg]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #17721:
URL: https://github.com/apache/iceberg/pull/17721#issuecomment-5458280133
Thanks @charliec05 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark: Fix map value decoding in test helpers [iceberg]
Posted by "charliec05 (via GitHub)" <gi...@apache.org>.
charliec05 commented on PR #17721:
URL: https://github.com/apache/iceberg/pull/17721#issuecomment-5389020851
Hi @aokolnychyi, would you be willing to review this PR? It fixes map value decoding in the Spark test helpers consistently across Spark 3.5, 4.0, and 4.1. CI is green, and @ebyhr has already approved the change. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark: Fix map value decoding in test helpers [iceberg]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho merged PR #17721:
URL: https://github.com/apache/iceberg/pull/17721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org