[GitHub] [rocketmq] cserwen commented on a diff in pull request #4523: [ISSUE #4522] Fix topic route info not found in some case

[GitBox <gi...@apache.org>]

cserwen commented on code in PR #4523:
URL: https://github.com/apache/rocketmq/pull/4523#discussion_r909174265


##########
store/src/test/java/org/apache/rocketmq/store/dledger/DLedgerMultiPathTest.java:
##########
@@ -46,8 +46,8 @@ public void multiDirsStorageTest() throws Exception {
             DefaultMessageStore dLedgerStore = createDLedgerMessageStore(base, group, "n0", peers, multiStorePath, null);
             Thread.sleep(2000);
             doPutMessages(dLedgerStore, topic, 0, 1000, 0);
-            Assert.assertEquals(11, dLedgerStore.getMaxPhyOffset()/dLedgerStore.getMessageStoreConfig().getMappedFileSizeCommitLog());
             Thread.sleep(500);
+            Assert.assertEquals(11, dLedgerStore.getMaxPhyOffset()/dLedgerStore.getMessageStoreConfig().getMappedFileSizeCommitLog());

Review Comment:
   > Nice change here. I guess this is something that causes our CI to fail sometimes. Hope it works. How about making this a separate PR so that we could maybe merge it faster?
   
   @tsunghanjacktsai  Good suggestion, I'll deal with it later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org