You are viewing a plain text version of this content. The canonical link for it is here.
Posted to torque-dev@db.apache.org by "Thomas Fischer (JIRA)" <ji...@apache.org> on 2009/11/08 11:18:32 UTC
[jira] Created: (TORQUE-128) remove autoIncrement attribute of
column element
remove autoIncrement attribute of column element
------------------------------------------------
Key: TORQUE-128
URL: https://issues.apache.org/jira/browse/TORQUE-128
Project: Torque
Issue Type: Sub-task
Affects Versions: 4.0
Reporter: Thomas Fischer
In the 3.3 schema, the id method for a column is determined by the idMethod attribute of the table, the defaultIdMethod attribute of the database and the primaryKey attribute of the column. This is sufficient for determining the idMethod.
However, in the 3.3 schema, there is still the autoIncrement attribute which kind of overrides the settings outlined above. There is no such equivalent for sequence generation, thus the attribute is bad for database interoperability.
Therefore I'd suggest to remove this attribute with no replacement. The consequence would be that it would no longer be possible to have auto_increment on columns which are no primary key (but again, torque supports no such feature for sequence generation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] Commented: (TORQUE-128) remove autoIncrement attribute of
column element
Posted by "Thomas Vandahl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TORQUE-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907916#action_12907916 ]
Thomas Vandahl commented on TORQUE-128:
---------------------------------------
I tend to disagree. If I'm not mislead, I can have columns which are primary keys but have no auto-increment flag on (or no associated sequence, for that matter). N:M-tables are a typical example or tables with compound primary keys. How would you handle those? As I see it, this modification would impose a serious limitation on the way you describe database schemas with Torque.
Besides, Torque handles sequences just fine with database systems that support them.
> remove autoIncrement attribute of column element
> ------------------------------------------------
>
> Key: TORQUE-128
> URL: https://issues.apache.org/jira/browse/TORQUE-128
> Project: Torque
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Thomas Fischer
> Fix For: 4.0
>
>
> In the 3.3 schema, the id method for a column is determined by the idMethod attribute of the table, the defaultIdMethod attribute of the database and the primaryKey attribute of the column. This is sufficient for determining the idMethod.
> However, in the 3.3 schema, there is still the autoIncrement attribute which kind of overrides the settings outlined above. There is no such equivalent for sequence generation, thus the attribute is bad for database interoperability.
> Therefore I'd suggest to remove this attribute with no replacement. The consequence would be that it would no longer be possible to have auto_increment on columns which are no primary key (but again, torque supports no such feature for sequence generation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] Resolved: (TORQUE-128) remove autoIncrement attribute of
column element
Posted by "Thomas Fischer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TORQUE-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Fischer resolved TORQUE-128.
-----------------------------------
Fix Version/s: 4.0
Resolution: Fixed
Change made with Greg's transition to xsd
> remove autoIncrement attribute of column element
> ------------------------------------------------
>
> Key: TORQUE-128
> URL: https://issues.apache.org/jira/browse/TORQUE-128
> Project: Torque
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Thomas Fischer
> Fix For: 4.0
>
>
> In the 3.3 schema, the id method for a column is determined by the idMethod attribute of the table, the defaultIdMethod attribute of the database and the primaryKey attribute of the column. This is sufficient for determining the idMethod.
> However, in the 3.3 schema, there is still the autoIncrement attribute which kind of overrides the settings outlined above. There is no such equivalent for sequence generation, thus the attribute is bad for database interoperability.
> Therefore I'd suggest to remove this attribute with no replacement. The consequence would be that it would no longer be possible to have auto_increment on columns which are no primary key (but again, torque supports no such feature for sequence generation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] Commented: (TORQUE-128) remove autoIncrement attribute of
column element
Posted by "Thomas Vandahl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TORQUE-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908152#action_12908152 ]
Thomas Vandahl commented on TORQUE-128:
---------------------------------------
Well, I have no problem with the name. It actually exactly describes what it does for the column: "automatically increment its value" Just because others call this different we should not use foggy terms for simple things :-)
I would leave it in as-is.
> remove autoIncrement attribute of column element
> ------------------------------------------------
>
> Key: TORQUE-128
> URL: https://issues.apache.org/jira/browse/TORQUE-128
> Project: Torque
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Thomas Fischer
> Fix For: 4.0
>
>
> In the 3.3 schema, the id method for a column is determined by the idMethod attribute of the table, the defaultIdMethod attribute of the database and the primaryKey attribute of the column. This is sufficient for determining the idMethod.
> However, in the 3.3 schema, there is still the autoIncrement attribute which kind of overrides the settings outlined above. There is no such equivalent for sequence generation, thus the attribute is bad for database interoperability.
> Therefore I'd suggest to remove this attribute with no replacement. The consequence would be that it would no longer be possible to have auto_increment on columns which are no primary key (but again, torque supports no such feature for sequence generation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] Reopened: (TORQUE-128) remove autoIncrement attribute of
column element
Posted by "Thomas Fischer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TORQUE-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Fischer reopened TORQUE-128:
-----------------------------------
There is no problem on tables with composite primary key where none of the columns are automatically generated (set idMethod to none on table). This is the most common use case (e.g. the m:n table use case).
However, in the case of a composite key where only one column is autoincremented and the others are fixed, I now see that functionality is lost. This seems a rather exotic use case and on mysql does not do what I'd expect (see http://dev.mysql.com/doc/refman/5.0/en/example-auto-increment.html)
But even if we decide to keep the functionality, the flag should not be called autoincrement but also idMethod in my eyes. The name is most confusing on systems which do not use autoincrement but sequences. But I see the problem that it breaks backwards-compatibility for no compelling reason.
Please state your opinions on how to proceed.
> remove autoIncrement attribute of column element
> ------------------------------------------------
>
> Key: TORQUE-128
> URL: https://issues.apache.org/jira/browse/TORQUE-128
> Project: Torque
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Thomas Fischer
> Fix For: 4.0
>
>
> In the 3.3 schema, the id method for a column is determined by the idMethod attribute of the table, the defaultIdMethod attribute of the database and the primaryKey attribute of the column. This is sufficient for determining the idMethod.
> However, in the 3.3 schema, there is still the autoIncrement attribute which kind of overrides the settings outlined above. There is no such equivalent for sequence generation, thus the attribute is bad for database interoperability.
> Therefore I'd suggest to remove this attribute with no replacement. The consequence would be that it would no longer be possible to have auto_increment on columns which are no primary key (but again, torque supports no such feature for sequence generation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org