You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/05/07 19:31:39 UTC
[GitHub] [maven-integration-testing] alex1989hu opened a new pull request #59: [MNG-5600] Dependency management import should support exclusions
alex1989hu opened a new pull request #59:
URL: https://github.com/apache/maven-integration-testing/pull/59
The original patch is made by: Christian Schulte <sc...@apache.org>
@ChristianSchulte
For more information kindly ask you to visit the original pull request #30
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull request #59: [MNG-5600] Dependency management import should support exclusions
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #59:
URL: https://github.com/apache/maven-integration-testing/pull/59#discussion_r422099576
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5600DependencyManagementImportExclusionsTest.java
##########
@@ -0,0 +1,82 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import java.io.File;
+import java.util.Arrays;
+import java.util.Map;
+import java.util.Properties;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import static junit.framework.Assert.assertEquals;
+
+/**
+ * [MNG-5600] Dependency management import should support exclusions.
+ *
+ * @author Christian Schulte
+ */
+public class MavenITmng5600DependencyManagementImportExclusionsTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ public MavenITmng5600DependencyManagementImportExclusionsTest()
+ {
+ super( "[3.4.0,)" );
Review comment:
This version needs to be updated to 3.7.0
##########
File path: core-it-suite/src/test/resources/mng-5600/exclusions/pom.xml
##########
@@ -0,0 +1,84 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project>
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.maven.its.mng5600</groupId>
+ <artifactId>0</artifactId>
+ <version>20160619</version>
+ <packaging>pom</packaging>
+
+ <name>Maven Integration Test :: MNG-5600</name>
+
+ <description>
+ Tests that dependency management import exclusions are supported.
+ </description>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.maven.its.mng5600</groupId>
+ <artifactId>bom</artifactId>
+ <version>0</version>
+ <type>pom</type>
+ <scope>import</scope>
+ <exclusions>
Review comment:
This IT doesn't reflect MNG-5600. The requests asks for exclusion of transitive dependencies, not direct dependencies.
To me excluding direct dependencies does not make sense.
##########
File path: core-it-suite/src/test/resources/mng-5600/settings-template.xml
##########
@@ -0,0 +1,43 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
I don't understand the need for this file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] alex1989hu commented on a change in pull request #59: [MNG-5600] Dependency management import should support exclusions
Posted by GitBox <gi...@apache.org>.
alex1989hu commented on a change in pull request #59:
URL: https://github.com/apache/maven-integration-testing/pull/59#discussion_r422125693
##########
File path: core-it-suite/src/test/resources/mng-5600/settings-template.xml
##########
@@ -0,0 +1,43 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
The original author does not respond, so try to figure out. The repository contains 201 XML file with the same name but with different content. If you are familiar with IT tests in Maven you could tell is it needed or not. I guess the author wanted to follow convention.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] alex1989hu commented on a change in pull request #59: [MNG-5600] Dependency management import should support exclusions
Posted by GitBox <gi...@apache.org>.
alex1989hu commented on a change in pull request #59:
URL: https://github.com/apache/maven-integration-testing/pull/59#discussion_r422122863
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5600DependencyManagementImportExclusionsTest.java
##########
@@ -0,0 +1,82 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import java.io.File;
+import java.util.Arrays;
+import java.util.Map;
+import java.util.Properties;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import static junit.framework.Assert.assertEquals;
+
+/**
+ * [MNG-5600] Dependency management import should support exclusions.
+ *
+ * @author Christian Schulte
+ */
+public class MavenITmng5600DependencyManagementImportExclusionsTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ public MavenITmng5600DependencyManagementImportExclusionsTest()
+ {
+ super( "[3.4.0,)" );
Review comment:
Replaced to your proposal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] alex1989hu commented on a change in pull request #59: [MNG-5600] Dependency management import should support exclusions
Posted by GitBox <gi...@apache.org>.
alex1989hu commented on a change in pull request #59:
URL: https://github.com/apache/maven-integration-testing/pull/59#discussion_r422127512
##########
File path: core-it-suite/src/test/resources/mng-5600/exclusions/pom.xml
##########
@@ -0,0 +1,84 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project>
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.maven.its.mng5600</groupId>
+ <artifactId>0</artifactId>
+ <version>20160619</version>
+ <packaging>pom</packaging>
+
+ <name>Maven Integration Test :: MNG-5600</name>
+
+ <description>
+ Tests that dependency management import exclusions are supported.
+ </description>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.maven.its.mng5600</groupId>
+ <artifactId>bom</artifactId>
+ <version>0</version>
+ <type>pom</type>
+ <scope>import</scope>
+ <exclusions>
Review comment:
I don't get you. If you exclude a dependency, then the actual excluded dependency and its all transitive dependencies are excluded. Maybe I misinterpret the change. Please clarify it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org