You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Michael W Thelen <th...@cs.utah.edu> on 2004/09/14 04:54:13 UTC

Re: mod_mime passthrough for svn repository resources

dorian taylor <do...@foobarsystems.com> [2004-08-12 17:30:17]:
> with my particular application of subversion, i find it advantageous
> to have the mime types of the resources divined by apache, should
> they not be explicitly set by svn:mime-type. however, mod_mime
> returns DECLINED unless there is an r->filename present. the technique
> i used was to first modify mod_dav_svn's repos.c, then create a
> mod_perl header parser handler to supplant the bogus filename. the
> filename can be anything, as long as it ends with the name of the
> resource, as mod_mime does on actual operations on any files, but
> simply parses the extensions out of the name. now, there are security
> implications of passing in a path that stands the chance of actually
> existing elsewhere on the filesystem, so i took the original value
> (at this stage, the value of the <Location> block from which the
> dav module was invoked) and concatenated it to r->uri with a !, as
> i've seen occur elsewhere in svn code.

Thanks for the patch, I've filed it as issue #2049:
http://subversion.tigris.org/issues/show_bug.cgi?id=2049

-- 
Michael W Thelen
It is a mistake to think you can solve any major problems just with potatoes.
                -- Douglas Adams

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org