[GitHub] [druid] liran-funaro commented on issue #10321: [Proposal] Design for a Configurable Index Type

[GitBox <gi...@apache.org>]

liran-funaro commented on issue #10321:
URL: https://github.com/apache/druid/issues/10321#issuecomment-691852058


   @jihoonson Thank you for taking the time to review this proposal.
   
   >I'm assuming that those knobs will have default values and users usually don't have to worry about them. Is this right?
   
   Yes. They will be `@Nullable` and will be set to the default value in that case. E.g., for `OffheapIncrementalIndex.Spec`:
   ```java
       public Spec(
           final @JsonProperty("bufferSize") @Nullable Integer bufferSize,
           final @JsonProperty("cacheSize") @Nullable Integer cacheSize
       )
       {
         this.bufferSize = bufferSize != null && bufferSize > 0 ? bufferSize : DEFAULT_BUFFER_SIZE;
         this.cacheSize = cacheSize != null && cacheSize > this.bufferSize ? cacheSize : DEFAULT_CACHE_SIZE;
         // ...
       }
   ```
   
   > do you think it's stable enough or do you perhaps need to make some changes in the near future?
   
   Using the `@UnstableApi` seems like a good idea at this point.
   
   > I'm not sure how much it's slower compared to groupBy v2 or how much using Oak can help with its performance. You may want to look into concurrent processing in groupBy v2 more closely such as `ConcurrentGrouper`.
   
   I'll look into that. Improving query performance is on our agenda, and we considered comparing the groupBy v1 with Oak to the groupBy v2 mechanism. We will report our results in a different issue in the future.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org