You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/21 12:45:08 UTC
[GitHub] [flink] fsk119 opened a new pull request, #20334: [FLINK-28629][sql-gateway][hive] Allow to getCatalogs in the HiveServer2 Endpoint
fsk119 opened a new pull request, #20334:
URL: https://github.com/apache/flink/pull/20334
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*Implement getCatalogs in the HiveServer2 Endpoint.*
## Brief change log
- *Implement listCatalogs in the SqlGatewayService*
- *Implement GetCatalogs in the HiveServer2 Endpoint*
## Verifying this change
This change added tests and can be verified as follows:
- *Added list all catalogs in the `SqlGatewayServiceITCase`*
- *Use jdbc to fetch all catalogs in the `HiveServer2EndpointITCase`*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on pull request #20334: [FLINK-28629][sql-gateway][hive] Allow to getCatalogs in the HiveServer2 Endpoint
Posted by GitBox <gi...@apache.org>.
fsk119 commented on PR #20334:
URL: https://github.com/apache/flink/pull/20334#issuecomment-1205188541
The failed case is tracked by [FLINK-28789](https://issues.apache.org/jira/browse/FLINK-28789).
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20334: [FLINK-28629][sql-gateway][hive] Allow to getCatalogs in the HiveServer2 Endpoint
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20334:
URL: https://github.com/apache/flink/pull/20334#issuecomment-1191448994
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26337c502197934efad5634750439aff16bcbe16",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "26337c502197934efad5634750439aff16bcbe16",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 26337c502197934efad5634750439aff16bcbe16 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on pull request #20334: [FLINK-28629][sql-gateway][hive] Allow to getCatalogs in the HiveServer2 Endpoint
Posted by GitBox <gi...@apache.org>.
fsk119 commented on PR #20334:
URL: https://github.com/apache/flink/pull/20334#issuecomment-1205023736
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a diff in pull request #20334: [FLINK-28629][sql-gateway][hive] Allow to getCatalogs in the HiveServer2 Endpoint
Posted by GitBox <gi...@apache.org>.
wuchong commented on code in PR #20334:
URL: https://github.com/apache/flink/pull/20334#discussion_r936663070
##########
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/SqlGatewayServiceITCase.java:
##########
@@ -587,6 +592,20 @@ public void testRequestNonExistOperation() {
}
}
+ @Test
+ public void testGetOperationSchemaWhenOperationGetError() throws Exception {
+ runGetOperationSchemaUntilOperationIsReadyOrError(
+ () -> {
+ throw new SqlGatewayException("Artificial Exception.");
+ },
+ task ->
+ assertThatThrownBy(task::get)
+ .satisfies(
+ anyCauseMatches(
+ IllegalStateException.class,
+ "The result schema is available when the Operation is in FINISHED state but the current status is ERROR.")));
Review Comment:
nit: throws the root cause of the operation error if the status is ERROR?
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/endpoint/hive/HiveServer2Endpoint.java:
##########
@@ -390,7 +396,35 @@ public TGetTypeInfoResp GetTypeInfo(TGetTypeInfoReq tGetTypeInfoReq) throws TExc
@Override
public TGetCatalogsResp GetCatalogs(TGetCatalogsReq tGetCatalogsReq) throws TException {
- throw new UnsupportedOperationException(ERROR_MESSAGE);
+ TGetCatalogsResp resp = new TGetCatalogsResp();
+ try {
+ SessionHandle sessionHandle = toSessionHandle(tGetCatalogsReq.getSessionHandle());
+ Set<String> catalogNames = service.listCatalogs(sessionHandle);
Review Comment:
Should we call this in `service.submitOperation`? Because `CatalogManager` is not thread safe.
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/endpoint/hive/HiveServer2Endpoint.java:
##########
@@ -390,7 +396,35 @@ public TGetTypeInfoResp GetTypeInfo(TGetTypeInfoReq tGetTypeInfoReq) throws TExc
@Override
public TGetCatalogsResp GetCatalogs(TGetCatalogsReq tGetCatalogsReq) throws TException {
- throw new UnsupportedOperationException(ERROR_MESSAGE);
+ TGetCatalogsResp resp = new TGetCatalogsResp();
+ try {
+ SessionHandle sessionHandle = toSessionHandle(tGetCatalogsReq.getSessionHandle());
+ Set<String> catalogNames = service.listCatalogs(sessionHandle);
+ OperationHandle operationHandle =
+ service.submitOperation(
+ sessionHandle,
+ OperationType.LIST_CATALOGS,
+ () ->
+ new ResultSet(
+ EOS,
+ null,
+ GET_CATALOGS_SCHEMA,
+ catalogNames.stream()
+ .map(
+ name ->
+ GenericRowData.of(
+ StringData.fromString(
+ name)))
+ .collect(Collectors.toList())));
Review Comment:
Maybe we can extract this as util (convert `Collection<String>` into `List<RowData>`). I think this can be reused in many places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 closed pull request #20334: [FLINK-28629][sql-gateway][hive] Allow to getCatalogs in the HiveServer2 Endpoint
Posted by GitBox <gi...@apache.org>.
fsk119 closed pull request #20334: [FLINK-28629][sql-gateway][hive] Allow to getCatalogs in the HiveServer2 Endpoint
URL: https://github.com/apache/flink/pull/20334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on pull request #20334: [FLINK-28629][sql-gateway][hive] Allow to getCatalogs in the HiveServer2 Endpoint
Posted by GitBox <gi...@apache.org>.
fsk119 commented on PR #20334:
URL: https://github.com/apache/flink/pull/20334#issuecomment-1204798442
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on pull request #20334: [FLINK-28629][sql-gateway][hive] Allow to getCatalogs in the HiveServer2 Endpoint
Posted by GitBox <gi...@apache.org>.
fsk119 commented on PR #20334:
URL: https://github.com/apache/flink/pull/20334#issuecomment-1204735914
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org