You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2023/01/01 14:54:32 UTC
[GitHub] [skywalking-python] pg-yang commented on a diff in pull request #263: Enhance redis plugin to adapt Virtual Cache
pg-yang commented on code in PR #263:
URL: https://github.com/apache/skywalking-python/pull/263#discussion_r1059762098
##########
skywalking/plugins/sw_redis.py:
##########
@@ -27,6 +27,101 @@
}
note = """"""
+OPERATIONS_WRITE = set({'GETSET',
+ 'SET',
+ 'SETBIT',
+ 'SETEX ',
+ 'SETNX ',
+ 'SETRANGE',
+ 'STRLEN ',
+ 'MSET',
+ 'MSETNX ',
+ 'PSETEX',
+ 'INCR ',
+ 'INCRBY ',
+ 'INCRBYFLOAT',
+ 'DECR ',
+ 'DECRBY ',
+ 'APPEND ',
+ 'HMSET',
+ 'HSET',
+ 'HSETNX ',
+ 'HINCRBY',
+ 'HINCRBYFLOAT',
+ 'HDEL',
+ 'RPOPLPUSH',
+ 'RPUSH',
+ 'RPUSHX',
+ 'LPUSH',
+ 'LPUSHX',
+ 'LREM',
+ 'LTRIM',
+ 'LSET',
+ 'BRPOPLPUSH',
+ 'LINSERT',
+ 'SADD',
+ 'SDIFF',
+ 'SDIFFSTORE',
+ 'SINTERSTORE',
+ 'SISMEMBER',
+ 'SREM',
+ 'SUNION',
+ 'SUNIONSTORE',
+ 'SINTER',
+ 'ZADD',
+ 'ZINCRBY',
+ 'ZINTERSTORE',
+ 'ZRANGE',
+ 'ZRANGEBYLEX',
+ 'ZRANGEBYSCORE',
+ 'ZRANK',
+ 'ZREM',
+ 'ZREMRANGEBYLEX',
+ 'ZREMRANGEBYRANK',
+ 'ZREMRANGEBYSCORE',
+ 'ZREVRANGE',
+ 'ZREVRANGEBYSCORE',
+ 'ZREVRANK',
+ 'ZUNIONSTORE',
+ 'XADD',
+ 'XDEL',
+ 'DEL',
+ 'xtrim'})
Review Comment:
`xtrim`'s name style is different from others. Please confirm it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org