Re: svn commit: r1096157 - in /subversion/trunk/subversion/libsvn_subr: config_win.c stream.c

[Daniel Shahaf <d....@daniel.shahaf.name>]

stefan2@apache.org wrote on Sat, Apr 23, 2011 at 15:00:29 -0000:
> Modified: subversion/trunk/subversion/libsvn_subr/stream.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/stream.c?rev=1096157&r1=1096156&r2=1096157&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_subr/stream.c (original)
> +++ subversion/trunk/subversion/libsvn_subr/stream.c Sat Apr 23 15:00:29 2011
> @@ -855,7 +855,7 @@ skip_handler_apr(void *baton, apr_size_t
>     * happend and keep the *count==0 set earlier.
>     */
>    if ((offset != new_pos) || (current == 0))
> -    *count = new_pos - current;
> +    *count = (apr_size_t)(new_pos - current);
>  
>    return err;
>  }
> 

This is the skip API.  Would it be better to change the skip API to
allow a wider type for the COUNT return parameter?

And, by the way: svn_stream_skip()'s docstring doesn't specify an @since
clause.  (I haven't checked other docstrings.)  Isn't it new in 1.7?


>