You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/02/14 19:45:36 UTC

[GitHub] brandon-applied commented on issue #158: CB-13522 (iOS): Remove usage description

brandon-applied commented on issue #158: CB-13522 (iOS): Remove usage description
URL: https://github.com/apache/cordova-plugin-contacts/pull/158#issuecomment-365723115
 
 
   @jcesarmobile quick question - why was this change necessary? I've looked at the Jira issue and no mention of why this change was required? 
   
   Failing to include the usage description in the manner described in the updated readme just causes the plugin to crash the app as soon as I attempt to read the contacts. For anyone upgrading, this "fix" just breaks the app. Seems like this fix should at least have updated the plugin to call the error callback if no permission text is available rather than crash.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org