[GitHub] yifeim commented on a change in pull request #10946: Remove kvstore calls from FM example

[GitBox <gi...@apache.org>]

yifeim commented on a change in pull request #10946: Remove kvstore calls from FM example
URL: https://github.com/apache/incubator-mxnet/pull/10946#discussion_r188799809
 
 

 ##########
 File path: example/sparse/factorization_machine/train.py
 ##########
 @@ -75,6 +76,16 @@
     assert(args.data_train is not None and args.data_test is not None), \
           "dataset for training or test is missing"
 
+    def batch_row_ids(data_batch):
+        """ Generate row ids based on the current mini-batch """
+        idx = batch.data[0].indices
 
 Review comment:
   Typo: data_batch <=> batch. Also, consider what to do when the batch contains multiple data fields? To elaborate, if my batch.data contains multiple sources, provided through dictionary (order is not enforced), how do I address the correct field? batch.provide_data returned None to me. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services