You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/07 16:39:56 UTC

[GitHub] mahendra commented on a change in pull request #6512: Fix scheduled reports for mysql

mahendra commented on a change in pull request #6512: Fix scheduled reports for mysql
URL: https://github.com/apache/incubator-superset/pull/6512#discussion_r245718768
 
 

 ##########
 File path: setup.py
 ##########
 @@ -94,9 +94,6 @@ def get_git_sha():
         'thrift-sasl>=0.2.1',
         'unicodecsv',
         'unidecode>=0.04.21',
-        'croniter==0.3.25',
 
 Review comment:
   (apologies for the late reply here. I was on vacation and traveling)
   
   These dependencies are still needed, but they are specified in `requirements.txt` already. Did not want to keep it in two places.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org