You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/02/24 16:57:58 UTC

[GitHub] [incubator-yunikorn-k8shim] craigcondit commented on pull request #373: [YUNIKORN-1084] Update namespace handling in admission controller

craigcondit commented on pull request #373:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/373#issuecomment-1050060452


   > `parseRegexes` really needs a test
   > 
   > * garbage input causes failure
   > * more than 1 reg exp in string (split check)
   > * escape character, i.e. what happens with a , do we see expected result
   >   Just some sanity checks so we know it works
   
   Added more tests in latest commit. Have verified 100% coverage of all lines / branches in parseRegexes() and initAdmissionController().


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org