You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/08 19:11:39 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #6648: [pulsar-client] add api to wait for inflight messages while closing producer

merlimat commented on a change in pull request #6648: [pulsar-client] add api to wait for inflight messages while closing producer
URL: https://github.com/apache/pulsar/pull/6648#discussion_r405750762
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PartitionedProducerImpl.java
 ##########
 @@ -203,6 +203,10 @@ public boolean isConnected() {
 
     @Override
     public CompletableFuture<Void> closeAsync() {
+        return closeAsync(false);
+    }
+
+    public CompletableFuture<Void> closeAsync(boolean waitForPendingMessages) {
 
 Review comment:
   This method can now be deleted

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services