You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/09/26 12:09:46 UTC
[GitHub] [incubator-livy] codecov-io edited a comment on issue #236:
[LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
codecov-io edited a comment on issue #236: [LIVY-678] Thrift ldap authentication, based on ldapurl, basedn, domain
URL: https://github.com/apache/incubator-livy/pull/236#issuecomment-534452181
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr&el=h1) Report
> Merging [#236](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/b8251eb9b3d63c77c61a5950dee5958b654d9633?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #236 +/- ##
============================================
+ Coverage 68.37% 68.44% +0.07%
Complexity 921 921
============================================
Files 100 100
Lines 5729 5736 +7
Branches 871 871
============================================
+ Hits 3917 3926 +9
+ Misses 1247 1246 -1
+ Partials 565 564 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.01% <100%> (+0.14%)` | `21 <0> (ø)` | :arrow_down: |
| [...ain/scala/org/apache/livy/utils/SparkYarnApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya1lhcm5BcHAuc2NhbGE=) | `66.01% <0%> (-1.31%)` | `40% <0%> (ø)` | |
| [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `78.81% <0%> (+0.84%)` | `41% <0%> (ø)` | :arrow_down: |
| [...c/main/scala/org/apache/livy/repl/ReplDriver.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr&el=tree#diff-cmVwbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvcmVwbC9SZXBsRHJpdmVyLnNjYWxh) | `33.33% <0%> (+2.56%)` | `7% <0%> (ø)` | :arrow_down: |
| [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/236/diff?src=pr&el=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `55.88% <0%> (+2.94%)` | `7% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr&el=footer). Last update [b8251eb...bda47d7](https://codecov.io/gh/apache/incubator-livy/pull/236?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services