[GitHub] [flink] JingsongLi commented on a change in pull request #9377: [FLINK-13561][table-planner-blink] Verify and correct time function's semantic for Blink planner

[GitBox <gi...@apache.org>]

JingsongLi commented on a change in pull request #9377: [FLINK-13561][table-planner-blink] Verify and correct time function's semantic for Blink planner
URL: https://github.com/apache/flink/pull/9377#discussion_r311631598
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala
 ##########
 @@ -3971,7 +3971,7 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
   }
 
   @Test
-  def testFromUnixTimeInUTC(): Unit = {
+  def testFromUnixTime(): Unit = {
 
 Review comment:
   should add FromUnixTime cases to `TemporalTypesTest`, there are many time zone env, like shanghai, DaylightSaving and etc.
   Same to UnixTimestamp.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services