You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/04/23 17:21:16 UTC
[kudu-CR] [backup] Cleanup a TODO comments
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13085
Change subject: [backup] Cleanup a TODO comments
......................................................................
[backup] Cleanup a TODO comments
This patch reviews the open TODO items in the Kudu
backup and restore code. It either addresses them,
removes them, or opens a jira to track them.
The fixed TODO items are:
- Support backups using follower replicas
- Reviewed backup command line options
- Hides “experimental” options
Change-Id: Ia03dd12b22988763640ff19f331ebe75e3cb5d6f
---
M java/kudu-backup/src/main/protobuf/backup.proto
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/BackupGraph.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/SessionIO.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
A java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
10 files changed, 152 insertions(+), 81 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/13085/1
--
To view, visit http://gerrit.cloudera.org:8080/13085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia03dd12b22988763640ff19f331ebe75e3cb5d6f
Gerrit-Change-Number: 13085
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [backup] Cleanup backup/restore TODO comments
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13085
to look at the new patch set (#2).
Change subject: [backup] Cleanup backup/restore TODO comments
......................................................................
[backup] Cleanup backup/restore TODO comments
This patch reviews the open TODO items in the Kudu
backup and restore code. It either addresses them,
removes them, or opens a jira to track them.
The fixed TODO items are:
- Support backups using follower replicas
- Reviewed backup command line options
- Hides “experimental” options
Change-Id: Ia03dd12b22988763640ff19f331ebe75e3cb5d6f
---
M java/kudu-backup/src/main/protobuf/backup.proto
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/BackupGraph.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/SessionIO.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
A java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
10 files changed, 152 insertions(+), 81 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/13085/2
--
To view, visit http://gerrit.cloudera.org:8080/13085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia03dd12b22988763640ff19f331ebe75e3cb5d6f
Gerrit-Change-Number: 13085
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [backup] Cleanup backup/restore TODO comments
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13085 )
Change subject: [backup] Cleanup backup/restore TODO comments
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13085/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala:
http://gerrit.cloudera.org:8080/#/c/13085/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala@109
PS2, Line 109: private case class KuduBackupPartition(index: Int, scanToken: Array[Byte], locations: Array[String])
: extends Partition
Having trouble following the Scala code; how is 'locations' used?
http://gerrit.cloudera.org:8080/#/c/13085/2/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala:
PS2:
The new tests seem somewhat fragile (i.e. they may need frequent updates as the options change), but if you think they're useful...
--
To view, visit http://gerrit.cloudera.org:8080/13085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia03dd12b22988763640ff19f331ebe75e3cb5d6f
Gerrit-Change-Number: 13085
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 18:06:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] [backup] Cleanup backup/restore TODO comments
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13085 )
Change subject: [backup] Cleanup backup/restore TODO comments
......................................................................
[backup] Cleanup backup/restore TODO comments
This patch reviews the open TODO items in the Kudu
backup and restore code. It either addresses them,
removes them, or opens a jira to track them.
The fixed TODO items are:
- Support backups using follower replicas
- Reviewed backup command line options
- Hides “experimental” options
Change-Id: Ia03dd12b22988763640ff19f331ebe75e3cb5d6f
Reviewed-on: http://gerrit.cloudera.org:8080/13085
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-backup/src/main/protobuf/backup.proto
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/BackupGraph.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/SessionIO.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
A java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
10 files changed, 152 insertions(+), 81 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia03dd12b22988763640ff19f331ebe75e3cb5d6f
Gerrit-Change-Number: 13085
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [backup] Cleanup backup/restore TODO comments
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13085 )
Change subject: [backup] Cleanup backup/restore TODO comments
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13085/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala:
http://gerrit.cloudera.org:8080/#/c/13085/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala@109
PS2, Line 109: private case class KuduBackupPartition(index: Int, scanToken: Array[Byte], locations: Array[String])
: extends Partition
> Having trouble following the Scala code; how is 'locations' used?
It's used in `getPreferredLocations` to pass to Spark see
`partition.asInstanceOf[KuduBackupPartition].locations`.
http://gerrit.cloudera.org:8080/#/c/13085/2/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala:
PS2:
> The new tests seem somewhat fragile (i.e. they may need frequent updates as
I view this as the most "public" api we currently have for backup and restore, so I am okay with the strictness. We can adjust it back in the future.
--
To view, visit http://gerrit.cloudera.org:8080/13085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia03dd12b22988763640ff19f331ebe75e3cb5d6f
Gerrit-Change-Number: 13085
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 19:19:33 +0000
Gerrit-HasComments: Yes