[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #5720: API: Add rowsCount to ScanTask

[GitBox <gi...@apache.org>]

aokolnychyi commented on code in PR #5720:
URL: https://github.com/apache/iceberg/pull/5720#discussion_r965724270


##########
core/src/test/java/org/apache/iceberg/TestDataTableScan.java:
##########
@@ -27,4 +34,56 @@ public TestDataTableScan(int formatVersion) {
   protected TableScan newScan() {
     return table.newScan();
   }
+
+  @Test
+  public void testTaskRowCounts() {
+    Assume.assumeTrue(formatVersion == 2);
+
+    DataFile dataFile1 = newDataFile("data_bucket=0");
+    table.newFastAppend().appendFile(dataFile1).commit();
+
+    DataFile dataFile2 = newDataFile("data_bucket=1");
+    table.newFastAppend().appendFile(dataFile2).commit();
+
+    DeleteFile deleteFile1 = newDeleteFile("data_bucket=0");
+    table.newRowDelta().addDeletes(deleteFile1).commit();
+
+    DeleteFile deleteFile2 = newDeleteFile("data_bucket=1");
+    table.newRowDelta().addDeletes(deleteFile2).commit();
+
+    TableScan scan = table.newScan().option(TableProperties.SPLIT_SIZE, String.valueOf(50));

Review Comment:
   Yeah, I think I copied it from somewhere else. I'll change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org