You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Roman Kalukiewicz (JIRA)" <ji...@apache.org> on 2009/08/06 10:27:35 UTC

[jira] Created: (CAMEL-1882) Aggregator fails permanently if exception thrown from aggregation strategy

Aggregator fails permanently if exception thrown from aggregation strategy
--------------------------------------------------------------------------

                 Key: CAMEL-1882
                 URL: https://issues.apache.org/activemq/browse/CAMEL-1882
             Project: Apache Camel
          Issue Type: Bug
          Components: camel-core
    Affects Versions: 2.0-M3
            Reporter: Roman Kalukiewicz
            Assignee: Roman Kalukiewicz
            Priority: Critical
             Fix For: 2.0.0


{{BatchSender}} thread in {{BatchProcessor}} doesn't expect any error thrown from {{Collection.add()}} method, so when it is thrown the whole thread dies and is never recovered. In Aggregator, where aggregation strategy exists such exceptions can be easily thrown from {{Collection.add()}} and can render Aggregator unusable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1882) Aggregator fails permanently if exception thrown from aggregation strategy

Posted by "Roman Kalukiewicz (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53500#action_53500 ] 

Roman Kalukiewicz commented on CAMEL-1882:
------------------------------------------

The problem also exists if exception is thrown from correlation expression - not only from aggregation strategy. The fix that is commited already also handles this scenario.

> Aggregator fails permanently if exception thrown from aggregation strategy
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-1882
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1882
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.0-M3
>            Reporter: Roman Kalukiewicz
>            Assignee: Roman Kalukiewicz
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> {{BatchSender}} thread in {{BatchProcessor}} doesn't expect any error thrown from {{Collection.add()}} method, so when it is thrown the whole thread dies and is never recovered. In Aggregator, where aggregation strategy exists such exceptions can be easily thrown from {{Collection.add()}} and can render Aggregator unusable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CAMEL-1882) Aggregator fails permanently if exception thrown from aggregation strategy

Posted by "Roman Kalukiewicz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roman Kalukiewicz resolved CAMEL-1882.
--------------------------------------

    Resolution: Fixed

Fix in r801545

The fix could be improved as errors are not handled using standard error handlers, but some error handler attached to BatchProcessor. I did it to fix the problem quickly. Moreover there is error handler already used in BatchProcessor, while I believe it should be removed at all and use standard error handler.

> Aggregator fails permanently if exception thrown from aggregation strategy
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-1882
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1882
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.0-M3
>            Reporter: Roman Kalukiewicz
>            Assignee: Roman Kalukiewicz
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> {{BatchSender}} thread in {{BatchProcessor}} doesn't expect any error thrown from {{Collection.add()}} method, so when it is thrown the whole thread dies and is never recovered. In Aggregator, where aggregation strategy exists such exceptions can be easily thrown from {{Collection.add()}} and can render Aggregator unusable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.