You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ew...@apache.org on 2016/12/30 05:03:34 UTC
kafka git commit: MINOR: Mx4jLoader always returns false even if mx4j
is loaded & started
Repository: kafka
Updated Branches:
refs/heads/trunk e79954637 -> 64bab8052
MINOR: Mx4jLoader always returns false even if mx4j is loaded & started
Mx4jLoader.scala should explicitly `return true` if the class is successfully loaded and started, otherwise it will return false even if the class is loaded.
Author: Edward Ribeiro <ed...@gmail.com>
Reviewers: Ewen Cheslack-Postava <ew...@confluent.io>
Closes #2295 from eribeiro/mx4jloader-bug
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/64bab805
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/64bab805
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/64bab805
Branch: refs/heads/trunk
Commit: 64bab80520e4a5452cd60de8e982ffd2be806ff7
Parents: e799546
Author: Edward Ribeiro <ed...@gmail.com>
Authored: Thu Dec 29 21:05:11 2016 -0800
Committer: Ewen Cheslack-Postava <me...@ewencp.org>
Committed: Thu Dec 29 21:05:11 2016 -0800
----------------------------------------------------------------------
core/src/main/scala/kafka/utils/Mx4jLoader.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/64bab805/core/src/main/scala/kafka/utils/Mx4jLoader.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/utils/Mx4jLoader.scala b/core/src/main/scala/kafka/utils/Mx4jLoader.scala
index 5d2549e..a959c4a 100644
--- a/core/src/main/scala/kafka/utils/Mx4jLoader.scala
+++ b/core/src/main/scala/kafka/utils/Mx4jLoader.scala
@@ -58,7 +58,7 @@ object Mx4jLoader extends Logging {
mbs.registerMBean(xsltProcessor, processorName)
httpAdaptorClass.getMethod("start").invoke(httpAdaptor)
info("mx4j successfuly loaded")
- true
+ return true
}
catch {
case _: ClassNotFoundException =>