You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2023/03/16 12:25:57 UTC
[GitHub] [spark] MaxGekk commented on a diff in pull request #40447: [SPARK-42816][CONNECT] Support Max Message size up to 128MB
MaxGekk commented on code in PR #40447:
URL: https://github.com/apache/spark/pull/40447#discussion_r1138560168
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -47,6 +47,16 @@ object Connect {
.bytesConf(ByteUnit.MiB)
.createWithDefaultString("4m")
+ val CONNECT_GRPC_MAX_INBOUND_MESSAGE_SIZE =
+ ConfigBuilder("spark.connect.grpc.maxInboundMessageSize")
+ .doc("""
+ |Sets the maximum inbound message size for the gRPC requests.
Review Comment:
Could you specify units, for example:
```suggestion
|Sets the maximum inbound message size in megabytes for the gRPC requests.
```
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -47,6 +47,16 @@ object Connect {
.bytesConf(ByteUnit.MiB)
.createWithDefaultString("4m")
+ val CONNECT_GRPC_MAX_INBOUND_MESSAGE_SIZE =
+ ConfigBuilder("spark.connect.grpc.maxInboundMessageSize")
+ .doc("""
+ |Sets the maximum inbound message size for the gRPC requests.
+ |Requests with a larger payload will fail.
Review Comment:
I don't think that injecting new lines is nice approach if we are going to format config docs somewhere else.
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -47,6 +47,16 @@ object Connect {
.bytesConf(ByteUnit.MiB)
.createWithDefaultString("4m")
+ val CONNECT_GRPC_MAX_INBOUND_MESSAGE_SIZE =
+ ConfigBuilder("spark.connect.grpc.maxInboundMessageSize")
+ .doc("""
+ |Sets the maximum inbound message size for the gRPC requests.
+ |Requests with a larger payload will fail.
+ |"""")
Review Comment:
```suggestion
|""")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org