You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Dennis Sosnoski (JIRA)" <ji...@apache.org> on 2011/01/22 11:31:43 UTC

[jira] Created: (CXF-3271) WS-RM code does not support InOrder assurances

WS-RM code does not support InOrder assurances
----------------------------------------------

                 Key: CXF-3271
                 URL: https://issues.apache.org/jira/browse/CXF-3271
             Project: CXF
          Issue Type: Bug
          Components: WS-* Components
    Affects Versions: 2.3.2
            Reporter: Dennis Sosnoski
            Priority: Critical


The WS-RM implementation does not support InOrder assurances. When InOrder is used alone (which is effectively the same as combined with AtLeastOnce) or with AtMostOnce messages are just delivered in whatever order they arrive. When InOrder is combined with ExactlyOnce the code never delivers any messages (due to a logic error in DestinationSequence.allPredecessorsAcknowledged()). See attached integration test and policy documents to demonstrate the issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CXF-3271) WS-RM code does not support InOrder assurances

Posted by "Dennis Sosnoski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Sosnoski updated CXF-3271:
---------------------------------

    Attachment: inorder.zip

Files to go into /systests/ws-specs/src/test/java/org/apache/cxf/systest/ws/rm

> WS-RM code does not support InOrder assurances
> ----------------------------------------------
>
>                 Key: CXF-3271
>                 URL: https://issues.apache.org/jira/browse/CXF-3271
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.3.2
>            Reporter: Dennis Sosnoski
>            Priority: Critical
>         Attachments: inorder.zip
>
>
> The WS-RM implementation does not support InOrder assurances. When InOrder is used alone (which is effectively the same as combined with AtLeastOnce) or with AtMostOnce messages are just delivered in whatever order they arrive. When InOrder is combined with ExactlyOnce the code never delivers any messages (due to a logic error in DestinationSequence.allPredecessorsAcknowledged()). See attached integration test and policy documents to demonstrate the issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CXF-3271) WS-RM code does not support InOrder assurances

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-3271.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.3.3
         Assignee: Daniel Kulp


Patch applied.

I modified the patch so that if continuations are available, it will use them instead of blocking on the thread.

One optimization that COULD be done is instead of wakeing up ALL the waiting continuations, we could just fine the one for the next in the sequence (and duplicates) and wake them up.  

Also, the Jetty continuations don't work with one-ways.  I'll need to figure out what to do about that.  Not sure it really matters for most cases though.   The fallback to the wait() method works fine.



> WS-RM code does not support InOrder assurances
> ----------------------------------------------
>
>                 Key: CXF-3271
>                 URL: https://issues.apache.org/jira/browse/CXF-3271
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.3.2
>            Reporter: Dennis Sosnoski
>            Assignee: Daniel Kulp
>            Priority: Critical
>             Fix For: 2.3.3
>
>         Attachments: CXF-3271-patch.txt, inorder.zip
>
>
> The WS-RM implementation does not support InOrder assurances. When InOrder is used alone (which is effectively the same as combined with AtLeastOnce) or with AtMostOnce messages are just delivered in whatever order they arrive. When InOrder is combined with ExactlyOnce the code never delivers any messages (due to a logic error in DestinationSequence.allPredecessorsAcknowledged()). See attached integration test and policy documents to demonstrate the issues.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CXF-3271) WS-RM code does not support InOrder assurances

Posted by "Dennis Sosnoski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986905#action_12986905 ] 

Dennis Sosnoski commented on CXF-3271:
--------------------------------------

Committed fix to https://svn.apache.org/repos/asf/cxf/sandbox/ws-rm-fixes (revision 1063642).

> WS-RM code does not support InOrder assurances
> ----------------------------------------------
>
>                 Key: CXF-3271
>                 URL: https://issues.apache.org/jira/browse/CXF-3271
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.3.2
>            Reporter: Dennis Sosnoski
>            Priority: Critical
>         Attachments: CXF-3271-patch.txt, inorder.zip
>
>
> The WS-RM implementation does not support InOrder assurances. When InOrder is used alone (which is effectively the same as combined with AtLeastOnce) or with AtMostOnce messages are just delivered in whatever order they arrive. When InOrder is combined with ExactlyOnce the code never delivers any messages (due to a logic error in DestinationSequence.allPredecessorsAcknowledged()). See attached integration test and policy documents to demonstrate the issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CXF-3271) WS-RM code does not support InOrder assurances

Posted by "Dennis Sosnoski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985295#action_12985295 ] 

Dennis Sosnoski edited comment on CXF-3271 at 1/23/11 6:28 AM:
---------------------------------------------------------------

Here's an Eclipse-generated patch to get InOrder working. It's not necessarily ideal, in that it still has a thread associated with each message waiting for its turn to be delivered (potentially including duplicate messages), but at least it gets the basics working.

Note that this includes the test code and files provided earlier to demonstrate the problem, so applying the patch is all that needs to be done.

      was (Author: dsosnoski):
    Here's an Eclipse-generated patch to get InOrder working. It's not necessarily ideal, in that it still has a thread associated with each message waiting for its turn to be delivered (potentially including duplicate messages), but at least it gets the basics working.
  
> WS-RM code does not support InOrder assurances
> ----------------------------------------------
>
>                 Key: CXF-3271
>                 URL: https://issues.apache.org/jira/browse/CXF-3271
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.3.2
>            Reporter: Dennis Sosnoski
>            Priority: Critical
>         Attachments: CXF-3271-patch.txt, inorder.zip
>
>
> The WS-RM implementation does not support InOrder assurances. When InOrder is used alone (which is effectively the same as combined with AtLeastOnce) or with AtMostOnce messages are just delivered in whatever order they arrive. When InOrder is combined with ExactlyOnce the code never delivers any messages (due to a logic error in DestinationSequence.allPredecessorsAcknowledged()). See attached integration test and policy documents to demonstrate the issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CXF-3271) WS-RM code does not support InOrder assurances

Posted by "Dennis Sosnoski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Sosnoski updated CXF-3271:
---------------------------------

    Attachment: CXF-3271-patch.txt

Here's an Eclipse-generated patch to get InOrder working. It's not necessarily ideal, in that it still has a thread associated with each message waiting for its turn to be delivered (potentially including duplicate messages), but at least it gets the basics working.

> WS-RM code does not support InOrder assurances
> ----------------------------------------------
>
>                 Key: CXF-3271
>                 URL: https://issues.apache.org/jira/browse/CXF-3271
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.3.2
>            Reporter: Dennis Sosnoski
>            Priority: Critical
>         Attachments: CXF-3271-patch.txt, inorder.zip
>
>
> The WS-RM implementation does not support InOrder assurances. When InOrder is used alone (which is effectively the same as combined with AtLeastOnce) or with AtMostOnce messages are just delivered in whatever order they arrive. When InOrder is combined with ExactlyOnce the code never delivers any messages (due to a logic error in DestinationSequence.allPredecessorsAcknowledged()). See attached integration test and policy documents to demonstrate the issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CXF-3271) WS-RM code does not support InOrder assurances

Posted by "Dennis Sosnoski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986905#action_12986905 ] 

Dennis Sosnoski edited comment on CXF-3271 at 1/26/11 4:10 AM:
---------------------------------------------------------------

Committed fix to https://svn.apache.org/repos/asf/cxf/sandbox/ws-rm-fixes (revision 1063646).

      was (Author: dsosnoski):
    Committed fix to https://svn.apache.org/repos/asf/cxf/sandbox/ws-rm-fixes (revision 1063642).
  
> WS-RM code does not support InOrder assurances
> ----------------------------------------------
>
>                 Key: CXF-3271
>                 URL: https://issues.apache.org/jira/browse/CXF-3271
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.3.2
>            Reporter: Dennis Sosnoski
>            Priority: Critical
>         Attachments: CXF-3271-patch.txt, inorder.zip
>
>
> The WS-RM implementation does not support InOrder assurances. When InOrder is used alone (which is effectively the same as combined with AtLeastOnce) or with AtMostOnce messages are just delivered in whatever order they arrive. When InOrder is combined with ExactlyOnce the code never delivers any messages (due to a logic error in DestinationSequence.allPredecessorsAcknowledged()). See attached integration test and policy documents to demonstrate the issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CXF-3271) WS-RM code does not support InOrder assurances

Posted by "Dennis Sosnoski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Sosnoski updated CXF-3271:
---------------------------------

    Attachment:     (was: inorder.zip)

> WS-RM code does not support InOrder assurances
> ----------------------------------------------
>
>                 Key: CXF-3271
>                 URL: https://issues.apache.org/jira/browse/CXF-3271
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.3.2
>            Reporter: Dennis Sosnoski
>            Priority: Critical
>
> The WS-RM implementation does not support InOrder assurances. When InOrder is used alone (which is effectively the same as combined with AtLeastOnce) or with AtMostOnce messages are just delivered in whatever order they arrive. When InOrder is combined with ExactlyOnce the code never delivers any messages (due to a logic error in DestinationSequence.allPredecessorsAcknowledged()). See attached integration test and policy documents to demonstrate the issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CXF-3271) WS-RM code does not support InOrder assurances

Posted by "Dennis Sosnoski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Sosnoski updated CXF-3271:
---------------------------------

    Attachment: inorder.zip

Integration test and associated policy files, to be run from /systests/ws-specs/src/test/java/org/apache/cxf/systest/ws/rm

> WS-RM code does not support InOrder assurances
> ----------------------------------------------
>
>                 Key: CXF-3271
>                 URL: https://issues.apache.org/jira/browse/CXF-3271
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.3.2
>            Reporter: Dennis Sosnoski
>            Priority: Critical
>         Attachments: inorder.zip
>
>
> The WS-RM implementation does not support InOrder assurances. When InOrder is used alone (which is effectively the same as combined with AtLeastOnce) or with AtMostOnce messages are just delivered in whatever order they arrive. When InOrder is combined with ExactlyOnce the code never delivers any messages (due to a logic error in DestinationSequence.allPredecessorsAcknowledged()). See attached integration test and policy documents to demonstrate the issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.