You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Alok Lal <al...@hortonworks.com> on 2015/06/04 00:52:21 UTC

Review Request 35025: RANGER-529 Policy Validation: resources of a policy must match one of the resource hierarchies of the service def

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35025/
-----------------------------------------------------------

Review request for ranger, Gautam Borad and Madhan Neethiraj.


Bugs: RANGER-529
    https://issues.apache.org/jira/browse/RANGER-529


Repository: ranger


Description
-------

For example, a Hive policy should not specify both UDF and TBL/COL.  At the same time if neither TBL nor UDF is required (which isn't the case today for hive BTW, but if it were) then it should be possible to create a policy with just DB on it.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java caaf68f 
  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java d3bcc1a 
  agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerPolicyValidator.java 27c6318 
  agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceDefHelper.java 883b808 

Diff: https://reviews.apache.org/r/35025/diff/


Testing
-------

- Existing tests updated
- New tests added to simulate and detect this scenario
- Manual testing by invoking REST API to ensure that incorrect policy creation fails.


Thanks,

Alok Lal