[GitHub] [helix] xyuanlu commented on pull request #1609: Include Exception Message in Log of ZkBaseDataAccessor#get()

[GitBox <gi...@apache.org>]

xyuanlu commented on pull request #1609:
URL: https://github.com/apache/helix/pull/1609#issuecomment-763884250


   > Maybe we could also add the reason here?
   > 
   > ```
   >         } else if (Code.get(cb.getRc()) != Code.NONODE && throwException) {
   >           throw new HelixMetaDataAccessException(
   >               String.format("Failed to read node %s", paths.get(i)));
   > ```
   > 
   > Will be
   > 
   > ```
   > String.format("Failed to read node %s, return code: %s", paths.get(i)), Code.get(cb.getRc()));
   > ```
   
   TFTR. Nice suggestion. Updated.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org