You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/25 12:40:18 UTC
[GitHub] [tvm] zotanika opened a new pull request #8125: [Caffe Frontend] supporting group > 1 cases for Deconv op
zotanika opened a new pull request #8125:
URL: https://github.com/apache/tvm/pull/8125
- Handling `group > 1` cases, assuming `group == output channels`
- Simply decomposed into Relay `split`, `conv2d_transposed`, and multi-leveled `concatenate` ops.
- Added some test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zotanika commented on a change in pull request #8125: [Caffe Frontend] supporting group > 1 cases for Deconv op
Posted by GitBox <gi...@apache.org>.
zotanika commented on a change in pull request #8125:
URL: https://github.com/apache/tvm/pull/8125#discussion_r642907343
##########
File path: python/tvm/driver/tvmc/compiler.py
##########
@@ -38,7 +38,7 @@
@register_parser
def add_compile_parser(subparsers):
- """ Include parser for 'compile' subcommand """
Review comment:
I agree. I don't know why this format error is observed on the file untouched by me.
Once reverting the commit, the error bothers CI build again, [https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-8125/4/pipeline](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-8125/4/pipeline), this is why I touched `python/tvm/driver/tvmc/compiler.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zotanika commented on a change in pull request #8125: [Caffe Frontend] supporting group > 1 cases for Deconv op
Posted by GitBox <gi...@apache.org>.
zotanika commented on a change in pull request #8125:
URL: https://github.com/apache/tvm/pull/8125#discussion_r649764859
##########
File path: python/tvm/driver/tvmc/compiler.py
##########
@@ -38,7 +38,7 @@
@register_parser
def add_compile_parser(subparsers):
- """ Include parser for 'compile' subcommand """
Review comment:
Thank you @leandron, CI build looks working well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on a change in pull request #8125: [Caffe Frontend] supporting group > 1 cases for Deconv op
Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #8125:
URL: https://github.com/apache/tvm/pull/8125#discussion_r647257925
##########
File path: python/tvm/driver/tvmc/compiler.py
##########
@@ -38,7 +38,7 @@
@register_parser
def add_compile_parser(subparsers):
- """ Include parser for 'compile' subcommand """
Review comment:
Once you rebase this PR with the latest from `main`, you'll get #8194, which fixes all these formatting issues. See that Pr for more context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zotanika commented on pull request #8125: [Caffe Frontend] supporting group > 1 cases for Deconv op
Posted by GitBox <gi...@apache.org>.
zotanika commented on pull request #8125:
URL: https://github.com/apache/tvm/pull/8125#issuecomment-851845970
Added commit for splitting this PR from former Reduction PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #8125: [Caffe Frontend] supporting group > 1 cases for Deconv op
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #8125:
URL: https://github.com/apache/tvm/pull/8125#issuecomment-849009486
Please help to manage this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] FrozenGene commented on a change in pull request #8125: [Caffe Frontend] supporting group > 1 cases for Deconv op
Posted by GitBox <gi...@apache.org>.
FrozenGene commented on a change in pull request #8125:
URL: https://github.com/apache/tvm/pull/8125#discussion_r642862529
##########
File path: python/tvm/driver/tvmc/compiler.py
##########
@@ -38,7 +38,7 @@
@register_parser
def add_compile_parser(subparsers):
- """ Include parser for 'compile' subcommand """
Review comment:
Seems your format tool has some problem. You shouldn't touch this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zotanika commented on pull request #8125: [Caffe Frontend] supporting group > 1 cases for Deconv op
Posted by GitBox <gi...@apache.org>.
zotanika commented on pull request #8125:
URL: https://github.com/apache/tvm/pull/8125#issuecomment-861443441
reopened #8260 on a clean branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] FrozenGene commented on pull request #8125: [Caffe Frontend] supporting group > 1 cases for Deconv op
Posted by GitBox <gi...@apache.org>.
FrozenGene commented on pull request #8125:
URL: https://github.com/apache/tvm/pull/8125#issuecomment-850354234
@zotanika Do you mind splitting two PRs ? One for Deconv, another is for reduction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen edited a comment on pull request #8125: [Caffe Frontend] supporting group > 1 cases for Deconv op
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #8125:
URL: https://github.com/apache/tvm/pull/8125#issuecomment-849009486
@FrozenGene Please help to manage this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zotanika closed pull request #8125: [Caffe Frontend] supporting group > 1 cases for Deconv op
Posted by GitBox <gi...@apache.org>.
zotanika closed pull request #8125:
URL: https://github.com/apache/tvm/pull/8125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org