You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jason Zhou <ja...@gmail.com> on 2024/08/23 17:45:23 UTC

Review Request 75191: [docs] Add public docs for Cgroups v2

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75191/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

Currently there is no official documentation outlining the changes
we have been making to support Cgroups v2.

We add a main document outlining how Mesos interacts with Cgroups v2,
and update some documents on the changes that were made, such as
the device isolator document.


Diffs
-----

  docs/cgroups2-support.md PRE-CREATION 
  docs/isolators/cgroups-devices.md 0807bd79eb27de437ac2773c7c8760a1bc03afa3 
  docs/mesos-containerizer.md 9a7b25d2b94073faa760da514d449ec175423745 


Diff: https://reviews.apache.org/r/75191/diff/1/


Testing
-------


Thanks,

Jason Zhou

Re: Review Request 75191: [docs] Add public docs for Cgroups v2

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75191/#review226883
-----------------------------------------------------------


Fix it, then Ship it!





docs/cgroups2-support.md
Lines 37-38 (patched)
<https://reviews.apache.org/r/75191/#comment315163>

    is this true?



docs/cgroups2-support.md
Lines 80 (patched)
<https://reviews.apache.org/r/75191/#comment315164>

    recovered


- Benjamin Mahler


On Aug. 23, 2024, 5:45 p.m., Jason Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75191/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2024, 5:45 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently there is no official documentation outlining the changes
> we have been making to support Cgroups v2.
> 
> We add a main document outlining how Mesos interacts with Cgroups v2,
> and update some documents on the changes that were made, such as
> the device isolator document.
> 
> 
> Diffs
> -----
> 
>   docs/cgroups2-support.md PRE-CREATION 
>   docs/isolators/cgroups-devices.md 0807bd79eb27de437ac2773c7c8760a1bc03afa3 
>   docs/mesos-containerizer.md 9a7b25d2b94073faa760da514d449ec175423745 
> 
> 
> Diff: https://reviews.apache.org/r/75191/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Zhou
> 
>

Re: Review Request 75191: [docs] Add public docs for Cgroups v2

Posted by Jason Zhou <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75191/
-----------------------------------------------------------

(Updated Aug. 23, 2024, 6:57 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Remove agent section and fix typo


Repository: mesos


Description
-------

Currently there is no official documentation outlining the changes
we have been making to support Cgroups v2.

We add a main document outlining how Mesos interacts with Cgroups v2,
and update some documents on the changes that were made, such as
the device isolator document.


Diffs (updated)
-----

  docs/cgroups2-support.md PRE-CREATION 
  docs/isolators/cgroups-devices.md 0807bd79eb27de437ac2773c7c8760a1bc03afa3 
  docs/mesos-containerizer.md 9a7b25d2b94073faa760da514d449ec175423745 


Diff: https://reviews.apache.org/r/75191/diff/2/

Changes: https://reviews.apache.org/r/75191/diff/1-2/


Testing
-------


Thanks,

Jason Zhou