[GitHub] [helix] qqu0127 commented on a diff in pull request #2459: retryUntilConnected - add exponential backoff

["qqu0127 (via GitHub)" <gi...@apache.org>]

qqu0127 commented on code in PR #2459:
URL: https://github.com/apache/helix/pull/2459#discussion_r1185377140


##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -1965,6 +1968,8 @@ public <T> T retryUntilConnected(final Callable<T> callable)
     if (_monitor != null) {
       _monitor.increaseOutstandingRequestGauge();
     }
+    int retryCount = 1;

Review Comment:
   nit: not a big deal, but should we initialize it with 0? And change below `retryCount++` to `++retryCount`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org