[jira] (CALCITE-4956) calcite-avatica-go should post info when open connection

["maxwellguo (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4956 ]


    maxwellguo deleted comment on CALCITE-4956:
    -------------------------------------

was (Author: maxwellguo):
Thank you very much. 

> calcite-avatica-go should post info when open connection
> --------------------------------------------------------
>
>                 Key: CALCITE-4956
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4956
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica-go
>    Affects Versions: avatica-go-5.0.0
>            Reporter: maxwellguo
>            Assignee: Francis Chuang
>            Priority: Major
>
> see https://calcite.apache.org/avatica/docs/json_reference.html#openconnectionrequest 
> for openconnection request we can set info that is some key-value pairs .but for avatica-go we do not get the chance to post the info, though https://github.com/apache/calcite-avatica-go/blob/master/driver.go#L88 the code do set some info but after seeing the code https://github.com/apache/calcite-avatica-go/blob/master/driver.go#L61 we will know the info is nil, so the info will never be posted. 
> after reviewing the database/sql of go's source code, I found that the https://github.com/apache/calcite-avatica-go/blob/master/driver.go#L60  NewConnector will only go one input paramters that is dsn ,so if we want to post some info ,it is useless. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)