You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/07 23:02:21 UTC

[GitHub] [airflow] kazanzhy commented on issue #10288: gcs_to_bigquery using deprecated methods

kazanzhy commented on issue #10288:
URL: https://github.com/apache/airflow/issues/10288#issuecomment-988323907


   Hi all.
   I've tried to remove warnings during GCSToBigQueryOperator as in PR #20119 
   But as a result, I copied almost all code from `bq_hook.create_external_table` and `bq_hook.run_load` which made the operator's execute method very sophisticated.
   That's why I just switched from `cursor` method calls to `BigQueryHook` methods. In my opinion, these methods should not be deprecated.
   We need someplace for complex dict creation, like `configuration` for `bq_hook.insert_job()` or `table_recource` for `bq_hook.create_empty_table()`.
   In my opinion, better to keep this code in BigQueryHook and don't move to Operator. But maybe I'm wrong.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org