You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Archana kumari <ar...@gmail.com> on 2014/03/11 23:38:18 UTC
Review Request 19073: Fixed a TODO(bmahler): Consider namespacing stat for
each subsystem (e.g. cgroups::memory::stat and cgroups::cpuacct::stat).by
writing wrappers for stat in in each namespace.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19073/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Fixed a TODO(bmahler): Consider namespacing stat for each subsystem (e.g.
cgroups::memory::stat and cgroups::cpuacct::stat).by writing wrappers for stat in in
each namespace.
Diffs
-----
src/linux/cgroups.hpp 65f0958
Diff: https://reviews.apache.org/r/19073/diff/
Testing
-------
Thanks,
Archana kumari
Re: Review Request 19073: Fixed a TODO(bmahler): Consider namespacing stat
for each subsystem (e.g. cgroups::memory::stat and
cgroups::cpuacct::stat).by writing wrappers for stat in in each namespace.
Posted by Archana kumari <ar...@gmail.com>.
> On March 14, 2014, 6:31 a.m., Benjamin Hindman wrote:
> > src/linux/cgroups.hpp, line 401
> > <https://reviews.apache.org/r/19073/diff/1/?file=516753#file516753line401>
> >
> > These declarations look good, can you include the definitions (implementations) too please?
>
> Benjamin Hindman wrote:
> Ahh, I didn't see https://reviews.apache.org/r/19184, let's merge these two reviews so we have both the declarations and definitions in the same place.
https://reviews.apache.org/r/19184/ this is the actual patch..
- Archana
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19073/#review37172
-----------------------------------------------------------
On March 11, 2014, 10:38 p.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19073/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 10:38 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed a TODO(bmahler): Consider namespacing stat for each subsystem (e.g.
> cgroups::memory::stat and cgroups::cpuacct::stat).by writing wrappers for stat in in
> each namespace.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 65f0958
>
> Diff: https://reviews.apache.org/r/19073/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>
Re: Review Request 19073: Fixed a TODO(bmahler): Consider namespacing stat
for each subsystem (e.g. cgroups::memory::stat and
cgroups::cpuacct::stat).by writing wrappers for stat in in each namespace.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On March 14, 2014, 6:31 a.m., Benjamin Hindman wrote:
> > src/linux/cgroups.hpp, line 401
> > <https://reviews.apache.org/r/19073/diff/1/?file=516753#file516753line401>
> >
> > These declarations look good, can you include the definitions (implementations) too please?
Ahh, I didn't see https://reviews.apache.org/r/19184, let's merge these two reviews so we have both the declarations and definitions in the same place.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19073/#review37172
-----------------------------------------------------------
On March 11, 2014, 10:38 p.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19073/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 10:38 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed a TODO(bmahler): Consider namespacing stat for each subsystem (e.g.
> cgroups::memory::stat and cgroups::cpuacct::stat).by writing wrappers for stat in in
> each namespace.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 65f0958
>
> Diff: https://reviews.apache.org/r/19073/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>
Re: Review Request 19073: Fixed a TODO(bmahler): Consider namespacing stat
for each subsystem (e.g. cgroups::memory::stat and
cgroups::cpuacct::stat).by writing wrappers for stat in in each namespace.
Posted by Archana kumari <ar...@gmail.com>.
> On March 14, 2014, 6:31 a.m., Benjamin Hindman wrote:
> > src/linux/cgroups.hpp, line 401
> > <https://reviews.apache.org/r/19073/diff/1/?file=516753#file516753line401>
> >
> > These declarations look good, can you include the definitions (implementations) too please?
>
> Benjamin Hindman wrote:
> Ahh, I didn't see https://reviews.apache.org/r/19184, let's merge these two reviews so we have both the declarations and definitions in the same place.
>
> Archana kumari wrote:
> https://reviews.apache.org/r/19184/ this is the actual patch..
please I would be greatful if you review the latest diff that I uploaded above
- Archana
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19073/#review37172
-----------------------------------------------------------
On March 11, 2014, 10:38 p.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19073/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 10:38 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed a TODO(bmahler): Consider namespacing stat for each subsystem (e.g.
> cgroups::memory::stat and cgroups::cpuacct::stat).by writing wrappers for stat in in
> each namespace.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 65f0958
>
> Diff: https://reviews.apache.org/r/19073/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>
Re: Review Request 19073: Fixed a TODO(bmahler): Consider namespacing stat
for each subsystem (e.g. cgroups::memory::stat and
cgroups::cpuacct::stat).by writing wrappers for stat in in each namespace.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19073/#review37172
-----------------------------------------------------------
src/linux/cgroups.hpp
<https://reviews.apache.org/r/19073/#comment68581>
These declarations look good, can you include the definitions (implementations) too please?
- Benjamin Hindman
On March 11, 2014, 10:38 p.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19073/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 10:38 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed a TODO(bmahler): Consider namespacing stat for each subsystem (e.g.
> cgroups::memory::stat and cgroups::cpuacct::stat).by writing wrappers for stat in in
> each namespace.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 65f0958
>
> Diff: https://reviews.apache.org/r/19073/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>
Re: Review Request 19073: Fixed a TODO(bmahler): Consider namespacing stat
for each subsystem (e.g. cgroups::memory::stat and
cgroups::cpuacct::stat).by writing wrappers for stat in in each namespace.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19073/#review36868
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19073]
All tests passed.
- Mesos ReviewBot
On March 11, 2014, 10:38 p.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19073/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 10:38 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed a TODO(bmahler): Consider namespacing stat for each subsystem (e.g.
> cgroups::memory::stat and cgroups::cpuacct::stat).by writing wrappers for stat in in
> each namespace.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 65f0958
>
> Diff: https://reviews.apache.org/r/19073/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>