You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Shri Javadekar <no...@github.com> on 2016/09/08 22:53:36 UTC
[jclouds/jclouds] JCLOUDS-1161: Make AWSS3BlobRequestSignerV4 the
default signer. (#1008)
Fix unit tests accordingly.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1008
-- Commit Summary --
* JCLOUDS-1161: Make AWSS3BlobRequestSignerV4 the default signer.
-- File Changes --
M providers/aws-s3/src/main/java/org/jclouds/aws/s3/blobstore/config/AWSS3BlobStoreContextModule.java (4)
M providers/aws-s3/src/test/java/org/jclouds/aws/s3/blobstore/AWSS3BlobSignerExpectTest.java (21)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/1008.patch
https://github.com/jclouds/jclouds/pull/1008.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1008
Re: [jclouds/jclouds] JCLOUDS-1161: Make AWSS3BlobRequestSignerV4 the
default signer. (#1008)
Posted by Shri Javadekar <no...@github.com>.
Do the live tests run successfully on current master? The same 4 tests above failed for me on current master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1008#issuecomment-246837745
Re: [jclouds/jclouds] JCLOUDS-1161: Make AWSS3BlobRequestSignerV4 the
default signer. (#1008)
Posted by Andrew Gaul <no...@github.com>.
Pushed to master as 7826d22d301b1a6accef2b7686700231ffba7e29.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1008#issuecomment-254708068
Re: [jclouds/jclouds] JCLOUDS-1161: Make AWSS3BlobRequestSignerV4 the
default signer. (#1008)
Posted by Andrew Gaul <no...@github.com>.
Closed #1008.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1008#event-828500622
Re: [jclouds/jclouds] JCLOUDS-1161: Make AWSS3BlobRequestSignerV4 the
default signer. (#1008)
Posted by Andrew Gaul <no...@github.com>.
Tests show the following errors:
```
$ mvn integration-test -pl :aws-s3 -Plive -Dtest.aws-s3.identity="${JCLOUDS_IDENTITY}" -Dtest.aws-s3.credential="${JCLOUDS_CREDENTIAL}" -Dtest=AWSS3BlobSignerLiveTest
...
Failed tests:
AWSS3BlobSignerLiveTest>S3BlobSignerLiveTest.testSignGetUrlWithTime:39->BaseBlobSignerLiveTest.testSignGetUrlWithTime:92->BaseBlobStoreIntegrationTest.assertConsistencyAwareContainerSize:311->BaseBlobStoreIntegrationTest.assertConsistencyAware:252->BaseBlobStoreIntegrationTest.assertConsistencyAware:239 » ContainerNotFound
AWSS3BlobSignerLiveTest>S3BlobSignerLiveTest.testSignPutUrlWithTime:60 null
AWSS3BlobSignerLiveTest>S3BlobSignerLiveTest.testSignGetUrlWithTimeExpired:49->BaseBlobSignerLiveTest.testSignGetUrlWithTimeExpired:115 » AWSResponse
AWSS3BlobSignerLiveTest>S3BlobSignerLiveTest.testSignPutUrlWithTimeExpired:69->BaseBlobSignerLiveTest.testSignPutUrlWithTimeExpired:179 » AWSResponse
Tests run: 8, Failures: 4, Errors: 0, Skipped: 0
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1008#issuecomment-246572568
Re: [jclouds/jclouds] JCLOUDS-1161: Make AWSS3BlobRequestSignerV4 the
default signer. (#1008)
Posted by Shri Javadekar <no...@github.com>.
Added a new live test, specifically run against eu-central-1 region.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1008#issuecomment-246511656
Re: [jclouds/jclouds] JCLOUDS-1161: Make AWSS3BlobRequestSignerV4 the
default signer. (#1008)
Posted by Andrew Gaul <no...@github.com>.
These four tests now succeed on master. You need to fix these two which fail with your change:
```
AWSS3BlobSignerLiveTest>S3BlobSignerLiveTest.testSignGetUrlWithTimeExpired:55->BaseBlobSignerLiveTest.testSignGetUrlWithTimeExpired:115 » AWSResponse
AWSS3BlobSignerLiveTest>S3BlobSignerLiveTest.testSignPutUrlWithTimeExpired:79->BaseBlobSignerLiveTest.testSignPutUrlWithTimeExpired:179 » AWSResponse
```
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1008#issuecomment-247804244
Re: [jclouds/jclouds] JCLOUDS-1161: Make AWSS3BlobRequestSignerV4 the
default signer. (#1008)
Posted by Shri Javadekar <no...@github.com>.
Thanks for fixing the tests on master @andrewgaul. I am able to run the tests successfully on master and also able to reproduce the test failures with my change. I'll fix them and upload a new commit.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1008#issuecomment-248364824
Re: [jclouds/jclouds] JCLOUDS-1161: Make AWSS3BlobRequestSignerV4 the
default signer. (#1008)
Posted by Ignasi Barrera <no...@github.com>.
>Is this change going to be included in jclouds 2.0
Yes!
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1008#issuecomment-254735506
Re: [jclouds/jclouds] JCLOUDS-1161: Make AWSS3BlobRequestSignerV4 the
default signer. (#1008)
Posted by Andrew Gaul <no...@github.com>.
Does this address any particular issue, e.g., using signed requests in eu-central-1 region? If so, please include an integration test.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1008#issuecomment-246054806
Re: [jclouds/jclouds] JCLOUDS-1161: Make AWSS3BlobRequestSignerV4 the
default signer. (#1008)
Posted by Ashkan Paya <no...@github.com>.
Is this change going to be included in jclouds 2.0 ?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1008#issuecomment-254653793