You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/13 03:10:35 UTC
[GitHub] [arrow] andreoss opened a new pull request, #14103: ARROW-4740: [Java] [flight] Update to Junit 5
andreoss opened a new pull request, #14103:
URL: https://github.com/apache/arrow/pull/14103
Update flight module to Junit 5
Relevant issue: https://issues.apache.org/jira/browse/ARROW-4740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #14103: ARROW-17704: [Java][FlightRPC] Update to Junit 5
Posted by GitBox <gi...@apache.org>.
lidavidm merged PR #14103:
URL: https://github.com/apache/arrow/pull/14103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #14103: ARROW-17704: [Java][FlightRPC] Update to Junit 5
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #14103:
URL: https://github.com/apache/arrow/pull/14103#issuecomment-1245451298
Great, thank you. I'll try to review this soon.
(Note that we generally use a single jira per PR, you can create jira sub-tasks for each PR if you like or just separate jiras)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14103: ARROW-17704: [Java][FlightRPC] Update to Junit 5
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14103:
URL: https://github.com/apache/arrow/pull/14103#issuecomment-1249987979
Benchmark runs are scheduled for baseline = 5e6da78a4f696a638ea93cb69ff89a8e070c0105 and contender = b48d2287bef95ed195f6e3721dd34f97fd1735c2. b48d2287bef95ed195f6e3721dd34f97fd1735c2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6432ec20066a459896e8899d2b9d1a61...6fc416fdfe4e4b2fa466d8cee6b5f545/)
[Failed :arrow_down:0.14% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/32a452c08107429e88f3de5387cc6c01...6dd1d8ae56c749fa85e0f51ebd9e781b/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/acf3fd6f58844a86b71f010e848add5d...82668627ab424a2dbda7ad1dc7fb926b/)
[Finished :arrow_down:0.28% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4d61427cd18b4bf497b4c4414e3fd375...5cb824690a8149a1ae3ee44cf8060d50/)
Buildkite builds:
[Finished] [`b48d2287` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1498)
[Finished] [`b48d2287` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1514)
[Failed] [`b48d2287` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1498)
[Finished] [`b48d2287` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1512)
[Finished] [`5e6da78a` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1497)
[Failed] [`5e6da78a` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1513)
[Failed] [`5e6da78a` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1497)
[Finished] [`5e6da78a` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1510)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andreoss commented on pull request #14103: ARROW-17704: [Java] [flight] Update to Junit 5
Posted by GitBox <gi...@apache.org>.
andreoss commented on PR #14103:
URL: https://github.com/apache/arrow/pull/14103#issuecomment-1245410108
@lidavidm Created a new Jira. I plan to convert other modules as well, will split into several PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14103: ARROW-17704: [Java][FlightRPC] Update to Junit 5
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14103:
URL: https://github.com/apache/arrow/pull/14103#issuecomment-1245572091
https://issues.apache.org/jira/browse/ARROW-17704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andreoss commented on a diff in pull request #14103: ARROW-17704: [Java][FlightRPC] Update to Junit 5
Posted by GitBox <gi...@apache.org>.
andreoss commented on code in PR #14103:
URL: https://github.com/apache/arrow/pull/14103#discussion_r972019960
##########
java/flight/flight-sql/src/test/java/org/apache/arrow/flight/TestFlightSql.java:
##########
@@ -67,12 +67,12 @@
import org.apache.arrow.vector.types.pojo.Schema;
import org.apache.arrow.vector.util.Text;
import org.hamcrest.Matcher;
-import org.junit.AfterClass;
-import org.junit.Assert;
-import org.junit.BeforeClass;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.ErrorCollector;
+import org.hamcrest.MatcherAssert;
Review Comment:
@lidavidm Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14103: ARROW-17704: [Java][FlightRPC] Update to Junit 5
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14103:
URL: https://github.com/apache/arrow/pull/14103#issuecomment-1245572137
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #14103: ARROW-17704: [Java][FlightRPC] Update to Junit 5
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #14103:
URL: https://github.com/apache/arrow/pull/14103#discussion_r972000973
##########
java/pom.xml:
##########
@@ -398,7 +398,14 @@
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
- <version>3.0.0-M7</version>
+ <version>2.22.2</version>
Review Comment:
Is there any way to avoid downgrading surefire?
##########
java/flight/flight-sql/src/test/java/org/apache/arrow/flight/TestFlightSql.java:
##########
@@ -67,12 +67,12 @@
import org.apache.arrow.vector.types.pojo.Schema;
import org.apache.arrow.vector.util.Text;
import org.hamcrest.Matcher;
-import org.junit.AfterClass;
-import org.junit.Assert;
-import org.junit.BeforeClass;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.ErrorCollector;
+import org.hamcrest.MatcherAssert;
Review Comment:
Note there's a merge conflict on this file now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andreoss commented on a diff in pull request #14103: ARROW-17704: [Java][FlightRPC] Update to Junit 5
Posted by GitBox <gi...@apache.org>.
andreoss commented on code in PR #14103:
URL: https://github.com/apache/arrow/pull/14103#discussion_r972013913
##########
java/pom.xml:
##########
@@ -398,7 +398,14 @@
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
- <version>3.0.0-M7</version>
+ <version>2.22.2</version>
Review Comment:
@lidavidm
I believe it's the same problem as reported here https://issues.apache.org/jira/browse/SUREFIRE-2033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14103: ARROW-17704: [Java][FlightRPC] Update to Junit 5
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14103:
URL: https://github.com/apache/arrow/pull/14103#issuecomment-1249988009
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/32a452c08107429e88f3de5387cc6c01...6dd1d8ae56c749fa85e0f51ebd9e781b/)
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/acf3fd6f58844a86b71f010e848add5d...82668627ab424a2dbda7ad1dc7fb926b/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14103: ARROW-4740: [Java] [flight] Update to Junit 5
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14103:
URL: https://github.com/apache/arrow/pull/14103#issuecomment-1244845139
https://issues.apache.org/jira/browse/ARROW-4740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #14103: ARROW-4740: [Java] [flight] Update to Junit 5
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #14103:
URL: https://github.com/apache/arrow/pull/14103#issuecomment-1245286043
Thank you!
ARROW-4740 is already resolved, would you mind creating a new Jira?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #14103: ARROW-17704: [Java][FlightRPC] Update to Junit 5
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #14103:
URL: https://github.com/apache/arrow/pull/14103#discussion_r972138198
##########
java/pom.xml:
##########
@@ -398,7 +398,14 @@
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
- <version>3.0.0-M7</version>
+ <version>2.22.2</version>
Review Comment:
Hmm. Is it possible to downgrade to only, say, 3.0.0-M4, and add a comment linking to the regression? Or otherwise, is it possible to configure the runners to avoid this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andreoss commented on a diff in pull request #14103: ARROW-17704: [Java][FlightRPC] Update to Junit 5
Posted by GitBox <gi...@apache.org>.
andreoss commented on code in PR #14103:
URL: https://github.com/apache/arrow/pull/14103#discussion_r972013913
##########
java/pom.xml:
##########
@@ -398,7 +398,14 @@
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
- <version>3.0.0-M7</version>
+ <version>2.22.2</version>
Review Comment:
@lidavidm
I believe it's related to https://issues.apache.org/jira/browse/SUREFIRE-2033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andreoss commented on a diff in pull request #14103: ARROW-17704: [Java][FlightRPC] Update to Junit 5
Posted by GitBox <gi...@apache.org>.
andreoss commented on code in PR #14103:
URL: https://github.com/apache/arrow/pull/14103#discussion_r972240630
##########
java/pom.xml:
##########
@@ -398,7 +398,14 @@
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
- <version>3.0.0-M7</version>
+ <version>2.22.2</version>
Review Comment:
@lidavidm Done. Fixed by adding extra decencies to surefire, the version remains '3.0.0-M7'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org