[GitHub] [jmeter] pmouawad commented on a change in pull request #632: Add Error Prone code style verification

[GitBox <gi...@apache.org>]

pmouawad commented on a change in pull request #632:
URL: https://github.com/apache/jmeter/pull/632#discussion_r507144507



##########
File path: src/bshclient/src/main/java/org/apache/jmeter/util/BeanShellClient.java
##########
@@ -80,7 +82,7 @@ public static void main(String [] args) throws Exception{
     private static void sendLine( String line, OutputStream outPipe )
     throws IOException
     {
-        outPipe.write( line.getBytes() ); // TODO - charset?
+        outPipe.write(line.getBytes(StandardCharsets.UTF_8));

Review comment:
       Are you sure about the potential breaks this might introduce ?

##########
File path: src/jorphan/src/main/java/org/apache/log/ContextMap.java
##########
@@ -53,7 +54,7 @@
     private final ContextMap m_parent;
 
     ///Container to hold map of elements
-    private Hashtable m_map = new Hashtable();
+    private HashMap<String, Object> m_map = new HashMap<>();

Review comment:
       Are you sure synchronization is not required ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org