You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/12 19:00:40 UTC
[GitHub] [airflow] kaxil opened a new pull request #11477: Add missing values entries to Parameters in chart/README.md
kaxil opened a new pull request #11477:
URL: https://github.com/apache/airflow/pull/11477
This PR Adds missing values entries to Parameters in chart/README.md
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #11477: Add missing values entries to Parameters in chart/README.md
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #11477:
URL: https://github.com/apache/airflow/pull/11477#issuecomment-707355122
@kaxil I figured we don't add it because a) there are no values for webserver and b) you can't add complex objects via CLI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11477: Add missing values entries to Parameters in chart/README.md
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11477:
URL: https://github.com/apache/airflow/pull/11477#issuecomment-707354158
@dimberman this was missing in https://github.com/apache/airflow/pull/11426
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #11477: Add missing values entries to Parameters in chart/README.md
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #11477:
URL: https://github.com/apache/airflow/pull/11477
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11477: Add missing values entries to Parameters in chart/README.md
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11477:
URL: https://github.com/apache/airflow/pull/11477#issuecomment-707356584
> @kaxil I figured we don't add it because a) there are no values for webserver and b) you can't add complex objects via CLI
In future we are going to automate generating this doc from `values.schema.json`. It is very useful to users to directly check what is configurable without having to look at values.yaml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #11477: Add missing values entries to Parameters in chart/README.md
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11477:
URL: https://github.com/apache/airflow/pull/11477#issuecomment-707368614
> In future we are going to automate generating this doc from values.schema.json. It is very useful to users to directly check what is configurable without having to look at values.yaml
Related: https://github.com/apache/airflow/issues/11077
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org