You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by stevengill <gi...@git.apache.org> on 2016/02/22 22:54:25 UTC
[GitHub] cordova-ios pull request: CB-10668 Moved node_modules to root
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-ios/pull/196
CB-10668 Moved node_modules to root
* updated package.json to include dependencies and bundledDependencies
* updated create.js to copy root node_modules instead of bin/node_modules
* removed bin/node_modules directory
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-ios master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/196.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #196
----
commit c1dcdf9de166a18a179f70f398efb60e82d2ee99
Author: Steve Gill <st...@gmail.com>
Date: 2016-02-22T21:47:04Z
CB-10668 updated create.js to grab node_modules from root, updated package.json
commit cc7f19112aa39ed946243193439659ae7bb1d833
Author: Steve Gill <st...@gmail.com>
Date: 2016-02-22T21:47:23Z
CB-10668 removed bin/node_modules
commit a7f059c01f14e99f67a01c7a37df96b913f9a15f
Author: Steve Gill <st...@gmail.com>
Date: 2016-02-22T21:48:25Z
CB-10668 checked in node_modules
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10668 Moved node_modules to root
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-ios/pull/196#issuecomment-187873089
Nothing to do with fetch. We noticed `npm pack` was not properly adding in nested node_modules for the latest `cordova-osx` release. I took this opportunity to quickly update both osx and ios to use `package.json` to manage dependencies like our other platforms.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10668 Moved node_modules to root
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10668 Moved node_modules to root
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-ios/pull/196#issuecomment-187815938
I'm curious - Is this required for the new npm fetch work? Does it mean older versions of cordova-ios will stop working with the new npm fetch approach?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org