You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2010/06/03 20:06:22 UTC

DO NOT REPLY [Bug 49381] New: Documentation error - createFreezePane

https://issues.apache.org/bugzilla/show_bug.cgi?id=49381

           Summary: Documentation error - createFreezePane
           Product: POI
           Version: 3.6
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: HSSF
        AssignedTo: dev@poi.apache.org
        ReportedBy: dajester2005@gmail.com


The documentation indicates that the last two arguments are column and row.

According to bug #47964, this is the correct order, however the method creates
a cell reference with the col/row backwards, causing the bottom of the
documentation to be true, which says the row comes before column (contradicting
the first line).

>From documentation:
================================================================

public void createFreezePane(int colSplit,
                             int rowSplit,
                             int leftmostColumn,
                             int topRow)

Creates a split (freezepane). Any existing freezepane or split pane is
overwritten. 

Specified by:
createFreezePane in interface Sheet
Parameters:
colSplit - Horizonatal position of split.
rowSplit - Vertical position of split.
topRow - Top row visible in bottom pane
leftmostColumn - Left column visible in right pane.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 49381] Documentation error - createFreezePane

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49381

--- Comment #4 from Giorgio Gallo <gi...@gmail.com> 2011-01-30 22:36:15 EST ---
Created an attachment (id=26578)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26578)
Test case

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 49381] Documentation error - createFreezePane

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49381

Giorgio Gallo <gi...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
           Platform|PC                          |All
            Version|3.6                         |3.7
         Resolution|FIXED                       |

--- Comment #2 from Giorgio Gallo <gi...@gmail.com> 2011-01-16 21:35:52 EST ---

Hi guys, I dare to reopen this issue, as docs & implementation still don't seem
to agree in 1.7.


A1 B1 | C1
----------
A2 B2 | C2 // C2 is at col 2, row 1


According to the docs, in order to get a split at cell C2 I should use

    sheet.createFreezePane(2, 1, 2, 1);

but indeed that does not work as expected, while this one does

    sheet.createFreezePane(2, 1, 1, 2);

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 49381] Documentation error - createFreezePane

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49381

--- Comment #3 from Nick Burch <ni...@alfresco.com> 2011-01-17 06:52:36 EST ---
Are you able to create a unit test that shows the result is wrong, or are you
only able to verify the issue by loading the file in excel afterwards?

If the former, please do create a unit test and upload it, so that can be used
for testing the fix, and ensuring it stays correct into the future

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 49381] Documentation error - createFreezePane

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49381

Nick Burch <ni...@alfresco.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Nick Burch <ni...@alfresco.com> 2011-03-18 12:39:18 EDT ---
Thanks for the test. It turns out that it was XSSF and not HSSF that was wrong
- the two params were the wrong way round in a CellReference

Fixed, and your unit test added, in r1082966.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 49381] Documentation error - createFreezePane

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49381

Giorgio Gallo <gi...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |giorgiga@gmail.com

--- Comment #5 from Giorgio Gallo <gi...@gmail.com> 2011-01-30 22:37:49 EST ---
Test case is attached.

(sorry for taking so long, Nick - I forgot to add myself as a watcher)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


DO NOT REPLY [Bug 49381] Documentation error - createFreezePane

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49381

Nick Burch <ni...@alfresco.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Nick Burch <ni...@alfresco.com> 2010-06-04 11:42:47 EDT ---
The documentation was correct, but slightly confusing - you need to track the
variable names, rather than blindly trusting the order of the params

It's confusing though, so fixed in r951453.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org