You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@age.apache.org by "rafsun42 (via GitHub)" <gi...@apache.org> on 2023/07/19 21:39:41 UTC
[GitHub] [age] rafsun42 opened a new issue, #1062: Update all regression tests (label redesign)
rafsun42 opened a new issue, #1062:
URL: https://github.com/apache/age/issues/1062
Two big changes were made to AGE with regards to vertex\edge ID.
1. All vertices use the sequence 'vertex_id_seq' to get their IDs as 'bigint'. Similarly, all edges use the sequence 'edge_id_seq' to get their IDs as 'bigint'. Before the change, vertex\edge would generate ID from their label ID.
2. Both vertex and edge table have a new column: 'label_id'::integer now.
Because of the changes, regression tests will now output new IDs, and have an extra 'label_id' column. Therefore, all '*.out' files in the '/regress/expected' folder needs to be updated.
Two diffs (before and after the change) of `cypher_create.out' are shown below, for example:
The goal of this task is to verify that the new *.out files (changes in green) are accurate. Here, **accurate means the new out files are precisely same as old ones except**:
1. New vertex\edge ID.
2. Extra label_id column.
To complete this task, you need to checkout to this branch: `label_redesign`. Compile on PG 13.9. Produce the new *.out files for comparison.
* Comment which new *.out files are accurate (**justify specifically why or why not**).
Note that, some tests will crash. They are not required to be worked on until the underlying issues are fixed and the 'label_redesign' branch is updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] CapnSpek commented on issue #1062: Update all regression tests (label redesign)
Posted by "CapnSpek (via GitHub)" <gi...@apache.org>.
CapnSpek commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1642896338
Please assign me this task!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] mohayu22 commented on issue #1062: Update all regression tests (label redesign)
Posted by "mohayu22 (via GitHub)" <gi...@apache.org>.
mohayu22 commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1643082277
Assign this to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] CapnSpek commented on issue #1062: Update all regression tests (label redesign)
Posted by "CapnSpek (via GitHub)" <gi...@apache.org>.
CapnSpek commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1644820045
I have created a Pull Request regarding updates to agtype.out https://github.com/rafsun42/age/pull/1
It is mainly about changing the ids and some delete messages.
The new ids are assigned in sequential order of creation of the vertices in a graph, and the tests have been updated to reflect the same.
Other than that some delete messages have been added and changed as per the new changes.
For example
```
NOTICE: drop cascades to 3 other objects
DETAIL: drop cascades to table orderability_graph._ag_label_vertex
```
Becomes
```
NOTICE: drop cascades to 5 other objects
DETAIL: drop cascades to sequence orderability_graph.vertex_id_seq
drop cascades to table orderability_graph._ag_label_vertex
drop cascades to sequence orderability_graph.edge_id_seq
```
And
```
NOTICE: drop cascades to 2 other objects
DETAIL: drop cascades to table agtype_null_duplicate_test._ag_label_vertex
```
Becomes
```
NOTICE: drop cascades to 4 other objects
DETAIL: drop cascades to sequence agtype_null_duplicate_test.vertex_id_seq
drop cascades to table agtype_null_duplicate_test._ag_label_vertex
drop cascades to sequence agtype_null_duplicate_test.edge_id_seq
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] CapnSpek commented on issue #1062: Update all regression tests (label redesign)
Posted by "CapnSpek (via GitHub)" <gi...@apache.org>.
CapnSpek commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1677204165
Current status of regression tests (categorized as fixed, need code changes, PR yet to merge): -
Fixed: -
label_redesgn_rafsun - ok
scan - Fixed (PR#3 https://github.com/rafsun42/age/pull/3 )
graphid - ok
agtype - Fixed (PR#1 https://github.com/rafsun42/age/pull/1 )
catalog - Fixed (PR#3 https://github.com/rafsun42/age/pull/3 )
cypher - Fixed (PR#3 https://github.com/rafsun42/age/pull/3 )
cypher_delete - Fixed (PR#11 https://github.com/rafsun42/age/pull/11 )
cypher_union - Fixed (PR#4 https://github.com/rafsun42/age/pull/4 )
cypher_call - Fixed (PR#4 https://github.com/rafsun42/age/pull/4 )
analyze - Fixed (PR#20 https://github.com/rafsun42/age/pull/20 )
name_validation - Fixed (PR#14 https://github.com/rafsun42/age/pull/14 )
drop - Fixed (PR#20 https://github.com/rafsun42/age/pull/20 )
Yet to merge: -
cypher_create - Yet to merge (PR#25 https://github.com/rafsun42/age/pull/25 )
cypher_merge - Yet to merge (PR#24 https://github.com/rafsun42/age/pull/24 )
age_global_graph - Yet to merge (PR#13 https://github.com/rafsun42/age/pull/13 )
index - Yet to merge (PR#19 https://github.com/rafsun42/age/pull/19 )
Need code changes: -
expr - Needs code changes
cypher_match - Needs code changes; Fixed other than code changes (PR#19 https://github.com/rafsun42/age/pull/19)
cypher_unwind - Needs code changes
cypher_set - Needs code changes
cypher_remove - Needs code changes
cypher_with - Needs code changes
cypher_vle - Needs code changes
age_load - Needs code changes
graph_generation - Needs code changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] CapnSpek commented on issue #1062: Update all regression tests (label redesign)
Posted by "CapnSpek (via GitHub)" <gi...@apache.org>.
CapnSpek commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1650823140
Tests that may require code changes.
File - cypher_match.out
```
Line 141
SELECT * FROM cypher('cypher_match', $$
MATCH (:v1)-[e]-() RETURN e
$$) AS (a agtype);
- a
----------------------------------------------------------------------------------------------------------------------------
- {"id": 1407374883553282, "label": "e1", "end_id": 1125899906842626, "start_id": 1125899906842625, "properties": {}}::edge
- {"id": 1407374883553281, "label": "e1", "end_id": 1125899906842627, "start_id": 1125899906842626, "properties": {}}::edge
- {"id": 1407374883553282, "label": "e1", "end_id": 1125899906842626, "start_id": 1125899906842625, "properties": {}}::edge
- {"id": 1407374883553281, "label": "e1", "end_id": 1125899906842627, "start_id": 1125899906842626, "properties": {}}::edge
-(4 rows)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('cypher_match', $$
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
Line 152
SELECT * FROM cypher('cypher_match', $$
MATCH (:v1)-[e]-(:v1) RETURN e
$$) AS (a agtype);
- a
----------------------------------------------------------------------------------------------------------------------------
- {"id": 1407374883553282, "label": "e1", "end_id": 1125899906842626, "start_id": 1125899906842625, "properties": {}}::edge
- {"id": 1407374883553281, "label": "e1", "end_id": 1125899906842627, "start_id": 1125899906842626, "properties": {}}::edge
- {"id": 1407374883553282, "label": "e1", "end_id": 1125899906842626, "start_id": 1125899906842625, "properties": {}}::edge
- {"id": 1407374883553281, "label": "e1", "end_id": 1125899906842627, "start_id": 1125899906842626, "properties": {}}::edge
-(4 rows)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('cypher_match', $$
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
SELECT * FROM cypher('cypher_match', $$
MATCH ()-[]-()-[e]-(:v1) RETURN e
$$) AS (a agtype);
- a
----------------------------------------------------------------------------------------------------------------------------
- {"id": 1407374883553282, "label": "e1", "end_id": 1125899906842626, "start_id": 1125899906842625, "properties": {}}::edge
- {"id": 1407374883553281, "label": "e1", "end_id": 1125899906842627, "start_id": 1125899906842626, "properties": {}}::edge
-(2 rows)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('cypher_match', $$
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
SELECT * FROM cypher('cypher_match', $$
MATCH (a)-[]-()-[]-(:v1) RETURN a
$$) AS (a agtype);
- a
-----------------------------------------------------------------------------------
- {"id": 1125899906842625, "label": "v1", "properties": {"id": "initial"}}::vertex
- {"id": 1125899906842627, "label": "v1", "properties": {"id": "end"}}::vertex
-(2 rows)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('cypher_match', $$
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
Line 230
SELECT * FROM cypher('cypher_match', $$
MATCH (:v1)-[e]->() RETURN e
$$) AS (a agtype);
- a
----------------------------------------------------------------------------------------------------------------------------
- {"id": 1407374883553281, "label": "e1", "end_id": 1125899906842627, "start_id": 1125899906842626, "properties": {}}::edge
- {"id": 1407374883553282, "label": "e1", "end_id": 1125899906842626, "start_id": 1125899906842625, "properties": {}}::edge
-(2 rows)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('cypher_match', $$
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
SELECT * FROM cypher('cypher_match', $$
MATCH ()-[e]->(:v1) RETURN e
$$) AS (a agtype);
- a
----------------------------------------------------------------------------------------------------------------------------
- {"id": 1407374883553281, "label": "e1", "end_id": 1125899906842627, "start_id": 1125899906842626, "properties": {}}::edge
- {"id": 1407374883553282, "label": "e1", "end_id": 1125899906842626, "start_id": 1125899906842625, "properties": {}}::edge
-(2 rows)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('cypher_match', $$
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
SELECT * FROM cypher('cypher_match', $$
MATCH (:v1)-[e]->(:v1) RETURN e
$$) AS (a agtype);
- a
----------------------------------------------------------------------------------------------------------------------------
- {"id": 1407374883553281, "label": "e1", "end_id": 1125899906842627, "start_id": 1125899906842626, "properties": {}}::edge
- {"id": 1407374883553282, "label": "e1", "end_id": 1125899906842626, "start_id": 1125899906842625, "properties": {}}::edge
-(2 rows)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('cypher_match', $$
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
Line 307
SELECT * FROM cypher('cypher_match', $$
MATCH (:v1)<-[e]-(:v1) RETURN e
$$) AS (a agtype);
- a
----------------------------------------------------------------------------------------------------------------------------
- {"id": 1407374883553281, "label": "e1", "end_id": 1125899906842627, "start_id": 1125899906842626, "properties": {}}::edge
- {"id": 1407374883553282, "label": "e1", "end_id": 1125899906842626, "start_id": 1125899906842625, "properties": {}}::edge
-(2 rows)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('cypher_match', $$
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
Line 357
SELECT * FROM cypher('cypher_match', $$
MATCH (:v2)<-[]-(:v2)-[]->(:v2)
MATCH p=()-[]->()
RETURN p
$$) AS (i agtype);
- i
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
- [{"id": 1125899906842625, "label": "v1", "properties": {"id": "initial"}}::vertex, {"id": 1407374883553282, "label": "e1", "end_id": 1125899906842626, "start_id": 1125899906842625, "properties": {}}::edge, {"id": 1125899906842626, "label": "v1", "properties": {"id": "middle"}}::vertex]::path
- [{"id": 1125899906842625, "label": "v1", "properties": {"id": "initial"}}::vertex, {"id": 1407374883553282, "label": "e1", "end_id": 1125899906842626, "start_id": 1125899906842625, "properties": {}}::edge, {"id": 1125899906842626, "label": "v1", "properties": {"id": "middle"}}::vertex]::path
- [{"id": 1125899906842626, "label": "v1", "properties": {"id": "middle"}}::vertex, {"id": 1407374883553281, "label": "e1", "end_id": 1125899906842627, "start_id": 1125899906842626, "properties": {}}::edge, {"id": 1125899906842627, "label": "v1", "properties": {"id": "end"}}::vertex]::path
- [{"id": 1125899906842626, "label": "v1", "properties": {"id": "middle"}}::vertex, {"id": 1407374883553281, "label": "e1", "end_id": 1125899906842627, "start_id": 1125899906842626, "properties": {}}::edge, {"id": 1125899906842627, "label": "v1", "properties": {"id": "end"}}::vertex]::path
- [{"id": 1688849860263938, "label": "v2", "properties": {"id": "middle"}}::vertex, {"id": 1970324836974594, "label": "e2", "end_id": 1688849860263937, "start_id": 1688849860263938, "properties": {}}::edge, {"id": 1688849860263937, "label": "v2", "properties": {"id": "initial"}}::vertex]::path
- [{"id": 1688849860263938, "label": "v2", "properties": {"id": "middle"}}::vertex, {"id": 1970324836974594, "label": "e2", "end_id": 1688849860263937, "start_id": 1688849860263938, "properties": {}}::edge, {"id": 1688849860263937, "label": "v2", "properties": {"id": "initial"}}::vertex]::path
- [{"id": 1688849860263938, "label": "v2", "properties": {"id": "middle"}}::vertex, {"id": 1970324836974593, "label": "e2", "end_id": 1688849860263939, "start_id": 1688849860263938, "properties": {}}::edge, {"id": 1688849860263939, "label": "v2", "properties": {"id": "end"}}::vertex]::path
- [{"id": 1688849860263938, "label": "v2", "properties": {"id": "middle"}}::vertex, {"id": 1970324836974593, "label": "e2", "end_id": 1688849860263939, "start_id": 1688849860263938, "properties": {}}::edge, {"id": 1688849860263939, "label": "v2", "properties": {"id": "end"}}::vertex]::path
-(8 rows)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('cypher_match', $$
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
SELECT * FROM cypher('cypher_match', $$
MATCH ()<-[]-(:v2)-[]->()
MATCH p=()-[]->()
RETURN p
$$) AS (i agtype);
- i
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
- [{"id": 1125899906842625, "label": "v1", "properties": {"id": "initial"}}::vertex, {"id": 1407374883553282, "label": "e1", "end_id": 1125899906842626, "start_id": 1125899906842625, "properties": {}}::edge, {"id": 1125899906842626, "label": "v1", "properties": {"id": "middle"}}::vertex]::path
- [{"id": 1125899906842625, "label": "v1", "properties": {"id": "initial"}}::vertex, {"id": 1407374883553282, "label": "e1", "end_id": 1125899906842626, "start_id": 1125899906842625, "properties": {}}::edge, {"id": 1125899906842626, "label": "v1", "properties": {"id": "middle"}}::vertex]::path
- [{"id": 1125899906842626, "label": "v1", "properties": {"id": "middle"}}::vertex, {"id": 1407374883553281, "label": "e1", "end_id": 1125899906842627, "start_id": 1125899906842626, "properties": {}}::edge, {"id": 1125899906842627, "label": "v1", "properties": {"id": "end"}}::vertex]::path
- [{"id": 1125899906842626, "label": "v1", "properties": {"id": "middle"}}::vertex, {"id": 1407374883553281, "label": "e1", "end_id": 1125899906842627, "start_id": 1125899906842626, "properties": {}}::edge, {"id": 1125899906842627, "label": "v1", "properties": {"id": "end"}}::vertex]::path
- [{"id": 1688849860263938, "label": "v2", "properties": {"id": "middle"}}::vertex, {"id": 1970324836974594, "label": "e2", "end_id": 1688849860263937, "start_id": 1688849860263938, "properties": {}}::edge, {"id": 1688849860263937, "label": "v2", "properties": {"id": "initial"}}::vertex]::path
- [{"id": 1688849860263938, "label": "v2", "properties": {"id": "middle"}}::vertex, {"id": 1970324836974594, "label": "e2", "end_id": 1688849860263937, "start_id": 1688849860263938, "properties": {}}::edge, {"id": 1688849860263937, "label": "v2", "properties": {"id": "initial"}}::vertex]::path
- [{"id": 1688849860263938, "label": "v2", "properties": {"id": "middle"}}::vertex, {"id": 1970324836974593, "label": "e2", "end_id": 1688849860263939, "start_id": 1688849860263938, "properties": {}}::edge, {"id": 1688849860263939, "label": "v2", "properties": {"id": "end"}}::vertex]::path
- [{"id": 1688849860263938, "label": "v2", "properties": {"id": "middle"}}::vertex, {"id": 1970324836974593, "label": "e2", "end_id": 1688849860263939, "start_id": 1688849860263938, "properties": {}}::edge, {"id": 1688849860263939, "label": "v2", "properties": {"id": "end"}}::vertex]::path
-(8 rows)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('cypher_match', $$
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
Line 409
SELECT * FROM cypher('cypher_match', $$
MATCH (:v3)-[b:e3]->()
RETURN b
$$) AS (i agtype);
- i
----------------------------------------------------------------------------------------------------------------------------
- {"id": 2533274790395905, "label": "e3", "end_id": 2251799813685250, "start_id": 2251799813685251, "properties": {}}::edge
- {"id": 2533274790395906, "label": "e3", "end_id": 2251799813685250, "start_id": 2251799813685249, "properties": {}}::edge
-(2 rows)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('cypher_match', $$
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
Line 466
SELECT * FROM cypher('cypher_match', $$
MATCH (a)-[]->(:v3)<-[]-(b)
where a.id = 'initial'
RETURN b
$$) AS (con_path agtype);
- con_path
-------------------------------------------------------------------------------
- {"id": 2251799813685251, "label": "v3", "properties": {"id": "end"}}::vertex
-(1 row)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('cypher_match', $$
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
Line 554
SELECT * FROM cypher('cypher_match', $$
MATCH (a:v)
MATCH (:v1)-[]-(c)
RETURN a.i, c.id
$$) AS (i agtype, c agtype);
- i | c
----+-----------
- | "initial"
- 0 | "initial"
- 1 | "initial"
- | "middle"
- 0 | "middle"
- 1 | "middle"
- | "middle"
- 0 | "middle"
- 1 | "middle"
- | "end"
- 0 | "end"
- 1 | "end"
-(12 rows)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('cypher_match', $$
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
Line 1554
SELECT * FROM cypher('cypher_match', $$
MATCH (u:duplicate)-[]-(:other_v)
RETURN DISTINCT u
$$) AS (i agtype);
- i
---------------------------------------------------------------------------
- {"id": 3377699720527873, "label": "duplicate", "properties": {}}::vertex
-(1 row)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('cypher_match', $$
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
Line 1783
SELECT * FROM cypher('test_retrieve_var', $$
MATCH (a:A)-[r:incs]->() WITH a, r
OPTIONAL MATCH (a)-[r]->(c)
WHERE EXISTS((:A)<-[]-(c))
RETURN a, r
$$) AS (a agtype, r agtype);
- a | r
------------------------------------------------------------------+----------------------------------------------------------------------------------------------------------------------------
- {"id": 844424930131969, "label": "A", "properties": {}}::vertex | {"id": 1125899906842625, "label": "incs", "end_id": 1407374883553281, "start_id": 844424930131969, "properties": {}}::edge
-(1 row)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('test_retrieve_var', $$
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
SELECT * FROM cypher('test_retrieve_var', $$
MATCH (a:A)-[r:incs]->() WITH a, r
OPTIONAL MATCH (a)-[r]->(c)
WHERE EXISTS((c)<-[]-(:A))
RETURN a, r
$$) AS (a agtype, r agtype);
- a | r
------------------------------------------------------------------+----------------------------------------------------------------------------------------------------------------------------
- {"id": 844424930131969, "label": "A", "properties": {}}::vertex | {"id": 1125899906842625, "label": "incs", "end_id": 1407374883553281, "start_id": 844424930131969, "properties": {}}::edge
-(1 row)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('test_retrieve_var', $$
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
SELECT * FROM cypher('test_retrieve_var', $$
MATCH (a:A)-[r:incs]->() WITH a, r
OPTIONAL MATCH (a)-[r]->(c)
WHERE EXISTS((:C)<-[]-(:A))
RETURN a, r
$$) AS (a agtype, r agtype);
- a | r
------------------------------------------------------------------+----------------------------------------------------------------------------------------------------------------------------
- {"id": 844424930131969, "label": "A", "properties": {}}::vertex | {"id": 1125899906842625, "label": "incs", "end_id": 1407374883553281, "start_id": 844424930131969, "properties": {}}::edge
-(1 row)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('test_retrieve_var', $$
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] CapnSpek commented on issue #1062: Update all regression tests (label redesign)
Posted by "CapnSpek (via GitHub)" <gi...@apache.org>.
CapnSpek commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1650853959
File - cypher_vle.out
Almost entire file.
`ERROR: match_vle_terminal_edge() argument 1 must be an agtype integer or a graphid`
File - age_load.out
Line 183
```
SELECT * FROM cypher('agload_test_graph', $$MATCH(n:Country {iso2 : 'BE'})
RETURN id(n), n.name, n.iso2 $$) as ("id(n)" agtype, "n.name" agtype, "n.iso2" agtype);
- id(n) | n.name | n.iso2
------------------+-----------+--------
- 844424930131990 | "Belgium" | "BE"
-(1 row)
-
+ERROR: graph_oid and label_id must not be null
SELECT * FROM cypher('agload_test_graph', $$MATCH(n:Country2 {iso2 : 'BE'})
RETURN id(n), n.name, n.iso2 $$) as ("id(n)" agtype, "n.name" agtype, "n.iso2" agtype);
- id(n) | n.name | n.iso2
-------------------+-----------+--------
- 1688849860263942 | "Belgium" | "BE"
-(1 row)
-
+ERROR: graph_oid and label_id must not be null
SELECT * FROM cypher('agload_test_graph', $$MATCH(n:Country {iso2 : 'AT'})
RETURN id(n), n.name, n.iso2 $$) as ("id(n)" agtype, "n.name" agtype, "n.iso2" agtype);
- id(n) | n.name | n.iso2
------------------+-----------+--------
- 844424930131983 | "Austria" | "AT"
-(1 row)
-
+ERROR: graph_oid and label_id must not be null
SELECT * FROM cypher('agload_test_graph', $$MATCH(n:Country2 {iso2 : 'AT'})
RETURN id(n), n.name, n.iso2 $$) as ("id(n)" agtype, "n.name" agtype, "n.iso2" agtype);
- id(n) | n.name | n.iso2
-------------------+-----------+--------
- 1688849860263940 | "Austria" | "AT"
-(1 row)
-
+ERROR: graph_oid and label_id must not be null
SELECT * FROM cypher('agload_test_graph', $$
MATCH (u:Country {region : "Europe"})
WHERE u.name =~ 'Cro.*'
RETURN u.name, u.region
$$) AS (result_1 agtype, result_2 agtype);
- result_1 | result_2
------------+----------
- "Croatia" | "Europe"
-(1 row)
-
+ERROR: graph_oid and label_id must not be null
```
File - graph_generation.out
Line 42
```
SELECT * FROM cypher('gp1', $$MATCH (a)-[e]->(b) RETURN e$$) as (n agtype);
- n
-----------------------------------------------------------------------------------------------------------------------------
- {"id": 1125899906842625, "label": "edges", "end_id": 844424930131970, "start_id": 844424930131969, "properties": {}}::edge
- {"id": 1125899906842629, "label": "edges", "end_id": 844424930131971, "start_id": 844424930131970, "properties": {}}::edge
- {"id": 1125899906842626, "label": "edges", "end_id": 844424930131971, "start_id": 844424930131969, "properties": {}}::edge
- {"id": 1125899906842630, "label": "edges", "end_id": 844424930131972, "start_id": 844424930131970, "properties": {}}::edge
- {"id": 1125899906842627, "label": "edges", "end_id": 844424930131972, "start_id": 844424930131969, "properties": {}}::edge
- {"id": 1125899906842632, "label": "edges", "end_id": 844424930131972, "start_id": 844424930131971, "properties": {}}::edge
- {"id": 1125899906842631, "label": "edges", "end_id": 844424930131973, "start_id": 844424930131970, "properties": {}}::edge
- {"id": 1125899906842634, "label": "edges", "end_id": 844424930131973, "start_id": 844424930131972, "properties": {}}::edge
- {"id": 1125899906842633, "label": "edges", "end_id": 844424930131973, "start_id": 844424930131971, "properties": {}}::edge
- {"id": 1125899906842628, "label": "edges", "end_id": 844424930131973, "start_id": 844424930131969, "properties": {}}::edge
-(10 rows)
-
+ERROR: graph_oid and label_id must not be null
Line 139
SELECT * FROM cypher('gp1', $$MATCH (a)-[e]->(b) RETURN e$$) as (n agtype);
- n
-----------------------------------------------------------------------------------------------------------------------------
- {"id": 1125899906842625, "label": "edges", "end_id": 844424930131970, "start_id": 844424930131969, "properties": {}}::edge
- {"id": 1125899906842629, "label": "edges", "end_id": 844424930131971, "start_id": 844424930131970, "properties": {}}::edge
- {"id": 1125899906842626, "label": "edges", "end_id": 844424930131971, "start_id": 844424930131969, "properties": {}}::edge
- {"id": 1125899906842627, "label": "edges", "end_id": 844424930131972, "start_id": 844424930131969, "properties": {}}::edge
- {"id": 1125899906842632, "label": "edges", "end_id": 844424930131972, "start_id": 844424930131971, "properties": {}}::edge
- {"id": 1125899906842630, "label": "edges", "end_id": 844424930131972, "start_id": 844424930131970, "properties": {}}::edge
- {"id": 1125899906842634, "label": "edges", "end_id": 844424930131973, "start_id": 844424930131972, "properties": {}}::edge
- {"id": 1125899906842628, "label": "edges", "end_id": 844424930131973, "start_id": 844424930131969, "properties": {}}::edge
- {"id": 1125899906842631, "label": "edges", "end_id": 844424930131973, "start_id": 844424930131970, "properties": {}}::edge
- {"id": 1125899906842633, "label": "edges", "end_id": 844424930131973, "start_id": 844424930131971, "properties": {}}::edge
- {"id": 1125899906842635, "label": "edges", "end_id": 844424930131975, "start_id": 844424930131974, "properties": {}}::edge
- {"id": 1125899906842639, "label": "edges", "end_id": 844424930131976, "start_id": 844424930131975, "properties": {}}::edge
- {"id": 1125899906842636, "label": "edges", "end_id": 844424930131976, "start_id": 844424930131974, "properties": {}}::edge
- {"id": 1125899906842637, "label": "edges", "end_id": 844424930131977, "start_id": 844424930131974, "properties": {}}::edge
- {"id": 1125899906842642, "label": "edges", "end_id": 844424930131977, "start_id": 844424930131976, "properties": {}}::edge
- {"id": 1125899906842640, "label": "edges", "end_id": 844424930131977, "start_id": 844424930131975, "properties": {}}::edge
- {"id": 1125899906842644, "label": "edges", "end_id": 844424930131978, "start_id": 844424930131977, "properties": {}}::edge
- {"id": 1125899906842638, "label": "edges", "end_id": 844424930131978, "start_id": 844424930131974, "properties": {}}::edge
- {"id": 1125899906842641, "label": "edges", "end_id": 844424930131978, "start_id": 844424930131975, "properties": {}}::edge
- {"id": 1125899906842643, "label": "edges", "end_id": 844424930131978, "start_id": 844424930131976, "properties": {}}::edge
- {"id": 1125899906842645, "label": "edges", "end_id": 844424930131978, "start_id": 844424930131969, "properties": {}}::edge
-(21 rows)
-
+ERROR: graph_oid and label_id must not be null
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] WendelLana commented on issue #1062: Update all regression tests (label redesign)
Posted by "WendelLana (via GitHub)" <gi...@apache.org>.
WendelLana commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1654587773
I've updated `cypher_create.out` file. It was basically just like Bhaskar has done with `agtype.out` file.
I changed the IDs and some delete messages to match the current logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] CapnSpek commented on issue #1062: Update all regression tests (label redesign)
Posted by "CapnSpek (via GitHub)" <gi...@apache.org>.
CapnSpek commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1644822321
The procedure I have followed is as such:
First I run the `make installcheck` command.
Then I check the `/regress/regression.diffs` file to see exactly which tests failed, the expected output and the obtained output.
I run the test myself in a separate database and check if the test fulfills its purpose, even if it does not follow the old expected result.
If it does, then I replace the old result in the expected file with the new result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] panosfol commented on issue #1062: Update all regression tests (label redesign)
Posted by "panosfol (via GitHub)" <gi...@apache.org>.
panosfol commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1648595069
I have updated the tests for `scan.out`, `catalog.out`, `cypher.out`, which was fairly simple because those tests had nothing to do with th ID's, just the number of tables and some other minor fixes.
Right now I'm in the process of updating `cypher_delete` file. They way I check if the vertices that are created are exactly the same as previously, but with the different ID, is to run the commands individually in both the version of PG13 and in the version of `label-redesign` branch.
In the new version the vertices have only one sequence. In the old version each label had its own sequence. But when a new vertex is created, If we add the number of all the label sequences, we should get the number of the vertex sequence in our new version.
Thats a way to ensure that the correct number of vertices are created and hold the corresponding `ID`. Its a bit tedious I know but it works from what I understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] WendelLana commented on issue #1062: Update all regression tests (label redesign)
Posted by "WendelLana (via GitHub)" <gi...@apache.org>.
WendelLana commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1644224880
Please assign me to this issue too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] mohayu22 commented on issue #1062: Update all regression tests (label redesign)
Posted by "mohayu22 (via GitHub)" <gi...@apache.org>.
mohayu22 commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1663683221
>
@rafsun42 @CapnSpek I have done a PR regarding errors in age_load.out and graph_generation.out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] CapnSpek commented on issue #1062: Update all regression tests (label redesign)
Posted by "CapnSpek (via GitHub)" <gi...@apache.org>.
CapnSpek commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1657308892
I will fix cypher_merge next.
And Mohayu will be doing analyze and drop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] CapnSpek commented on issue #1062: Update all regression tests (label redesign)
Posted by "CapnSpek (via GitHub)" <gi...@apache.org>.
CapnSpek commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1650223731
Regarding cypher_with.sql / cypher_with.out:
There is one test that may require some code changes.
It is test at line 87 of cypher_with.sql.
Or line 130 or cypher_with.out
```
SELECT * FROM cypher('cypher_with', $$
MATCH p = (m)-[*1..2]->(b)
WITH p, length(p) AS path_length
WHERE path_length > 1
RETURN p
$$) AS (pattern agtype);
```
The output is
```
2023-07-25 19:12:07.955 CEST [45148] ERROR: match_vle_terminal_edge() argument 1 must be an agtype integer or a graphid
2023-07-25 19:12:07.955 CEST [45148] STATEMENT: SELECT * FROM cypher('cypher_with', $$
MATCH p = (m)-[*1..2]->(b)
WITH p, length(p) AS path_length
WHERE path_length > 1
RETURN p
$$) AS (pattern agtype);
ERROR: match_vle_terminal_edge() argument 1 must be an agtype integer or a graphid
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] CapnSpek commented on issue #1062: Update all regression tests (label redesign)
Posted by "CapnSpek (via GitHub)" <gi...@apache.org>.
CapnSpek commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1650828739
Tests that may require code changes.
File - cypher_unwind
Line 150
```
SELECT * FROM cypher('cypher_unwind', $$
MATCH p=({name:'node1'})-[e:KNOWS*]->({name:'node3'})
UNWIND [p] as path
RETURN path
$$) as (i agtype);
- i
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
- [{"id": 281474976710657, "label": "_ag_label_vertex", "properties": {"a": [1, 2, 3], "name": "node1"}}::vertex, {"id": 844424930131969, "label": "KNOWS", "end_id": 281474976710658, "start_id": 281474976710657, "properties": {}}::edge, {"id": 281474976710658, "label": "_ag_label_vertex", "properties": {"a": [4, 5, 6], "name": "node2"}}::vertex, {"id": 844424930131970, "label": "KNOWS", "end_id": 281474976710659, "start_id": 281474976710658, "properties": {}}::edge, {"id": 281474976710659, "label": "_ag_label_vertex", "properties": {"a": [7, 8, 9], "name": "node3"}}::vertex]::path
-(1 row)
-
+ERROR: match_vle_terminal_edge() argument 1 must be an agtype integer or a graphid
SELECT * FROM cypher('cypher_unwind', $$
MATCH p=({name:'node1'})-[e:KNOWS*]->({name:'node3'})
UNWIND [p] as path
RETURN relationships(path)
$$) as (i agtype);
- i
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
- [{"id": 844424930131969, "label": "KNOWS", "end_id": 281474976710658, "start_id": 281474976710657, "properties": {}}::edge, {"id": 844424930131970, "label": "KNOWS", "end_id": 281474976710659, "start_id": 281474976710658, "properties": {}}::edge]
-(1 row)
-
+ERROR: match_vle_terminal_edge() argument 1 must be an agtype integer or a graphid
SELECT * FROM cypher('cypher_unwind', $$
MATCH p=({name:'node1'})-[e:KNOWS*]->({name:'node3'})
UNWIND [p] as path
UNWIND relationships(path) as edge
RETURN edge
$$) as (i agtype);
- i
----------------------------------------------------------------------------------------------------------------------------
- {"id": 844424930131969, "label": "KNOWS", "end_id": 281474976710658, "start_id": 281474976710657, "properties": {}}::edge
- {"id": 844424930131970, "label": "KNOWS", "end_id": 281474976710659, "start_id": 281474976710658, "properties": {}}::edge
-(2 rows)
-
+ERROR: match_vle_terminal_edge() argument 1 must be an agtype integer or a graphid
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] CapnSpek commented on issue #1062: Update all regression tests (label redesign)
Posted by "CapnSpek (via GitHub)" <gi...@apache.org>.
CapnSpek commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1677209630
As soon as the errors are fixed, we can quickly fix all the regression tests and create some more to test label redesign and multiple labels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] Zainab-Saad commented on issue #1062: Update all regression tests (label redesign)
Posted by "Zainab-Saad (via GitHub)" <gi...@apache.org>.
Zainab-Saad commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1643927106
Please assign me to this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] CapnSpek commented on issue #1062: Update all regression tests (label redesign)
Posted by "CapnSpek (via GitHub)" <gi...@apache.org>.
CapnSpek commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1650835679
Tests that may require code changes.
File - cypher_set.out
Line 165
```
SELECT * FROM cypher('cypher_set', $$MATCH ()-[n]->(:other_v) RETURN n$$) AS (a agtype);
- a
-----------------------------------------------------------------------------------------------------------------------------------------
- {"id": 1125899906842625, "label": "e", "end_id": 1407374883553281, "start_id": 281474976710657, "properties": {"i": 3, "j": 20}}::edge
- {"id": 1125899906842626, "label": "e", "end_id": 1407374883553282, "start_id": 844424930131969, "properties": {"i": 3, "j": 20}}::edge
- {"id": 1125899906842627, "label": "e", "end_id": 1407374883553283, "start_id": 844424930131971, "properties": {"i": 3, "j": 20}}::edge
- {"id": 1125899906842628, "label": "e", "end_id": 1407374883553284, "start_id": 844424930131970, "properties": {"i": 3, "j": 20}}::edge
-(4 rows)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('cypher_set', $$MATCH ()-[n]->(:other_v...
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
```
File - cypher_remove.out
Line 102
```
SELECT * FROM cypher('cypher_remove', $$CREATE (:test_4 { i : 20 } )-[:test_4_edge {j:20}]->(:test_4 {i:10})$$) AS (a agtype);
- a
--------------------------------------------------------------------------------------------------------------------------------------------
- {"id": 2251799813685249, "label": "test_4_edge", "end_id": 1970324836974594, "start_id": 1970324836974593, "properties": {"j": 20}}::edge
-(1 row)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('cypher_remove', $$MATCH ()-[n]->(:test...
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
SELECT * FROM cypher('cypher_remove', $$MATCH ()-[n]->(:test_4) RETURN n$$) AS (a agtype);
- a
--------------------------------------------------------------------------------------------------------------------------------------------
- {"id": 2251799813685249, "label": "test_4_edge", "end_id": 1970324836974594, "start_id": 1970324836974593, "properties": {"j": 20}}::edge
-(1 row)
-
+ERROR: function ag_catalog._extract_label_id(bigint) does not exist
+LINE 1: SELECT * FROM cypher('cypher_remove', $$MATCH ()-[n]->(:test...
+ ^
+HINT: No function matches the given name and argument types. You might need to add explicit type casts.
```
File - cypher_with.out
```
SELECT * FROM cypher('cypher_with', $$
MATCH p = (m)-[*1..2]->(b)
WITH p, length(p) AS path_length
WHERE path_length > 1
RETURN p
$$) AS (pattern agtype);
- pattern
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
- [{"id": 281474976710657, "label": "_ag_label_vertex", "properties": {"age": 36, "name": "Andres"}}::vertex, {"id": 1125899906842625, "label": "KNOWS", "end_id": 281474976710659, "start_id": 281474976710657, "properties": {}}::edge, {"id": 281474976710659, "label": "_ag_label_vertex", "properties": {"age": 55, "name": "Bossman"}}::vertex, {"id": 1125899906842627, "label": "KNOWS", "end_id": 281474976710661, "start_id": 281474976710659, "properties": {}}::edge, {"id": 281474976710661, "label": "_ag_label_vertex", "properties": {"age": 37, "name": "George"}}::vertex]::path
- [{"id": 281474976710657, "label": "_ag_label_vertex", "properties": {"age": 36, "name": "Andres"}}::vertex, {"id": 1125899906842625, "label": "KNOWS", "end_id": 281474976710659, "start_id": 281474976710657, "properties": {}}::edge, {"id": 281474976710659, "label": "_ag_label_vertex", "properties": {"age": 55, "name": "Bossman"}}::vertex, {"id": 844424930131970, "label": "BLOCKS", "end_id": 281474976710660, "start_id": 281474976710659, "properties": {}}::edge, {"id": 281474976710660, "label": "_ag_label_vertex", "properties": {"age": 35, "name": "David"}}::vertex]::path
- [{"id": 281474976710657, "label": "_ag_label_vertex", "properties": {"age": 36, "name": "Andres"}}::vertex, {"id": 844424930131969, "label": "BLOCKS", "end_id": 281474976710658, "start_id": 281474976710657, "properties": {}}::edge, {"id": 281474976710658, "label": "_ag_label_vertex", "properties": {"age": 25, "name": "Caesar"}}::vertex, {"id": 1125899906842626, "label": "KNOWS", "end_id": 281474976710661, "start_id": 281474976710658, "properties": {}}::edge, {"id": 281474976710661, "label": "_ag_label_vertex", "properties": {"age": 37, "name": "George"}}::vertex]::path
- [{"id": 281474976710659, "label": "_ag_label_vertex", "properties": {"age": 55, "name": "Bossman"}}::vertex, {"id": 844424930131970, "label": "BLOCKS", "end_id": 281474976710660, "start_id": 281474976710659, "properties": {}}::edge, {"id": 281474976710660, "label": "_ag_label_vertex", "properties": {"age": 35, "name": "David"}}::vertex, {"id": 1125899906842628, "label": "KNOWS", "end_id": 281474976710657, "start_id": 281474976710660, "properties": {}}::edge, {"id": 281474976710657, "label": "_ag_label_vertex", "properties": {"age": 36, "name": "Andres"}}::vertex]::path
- [{"id": 281474976710660, "label": "_ag_label_vertex", "properties": {"age": 35, "name": "David"}}::vertex, {"id": 1125899906842628, "label": "KNOWS", "end_id": 281474976710657, "start_id": 281474976710660, "properties": {}}::edge, {"id": 281474976710657, "label": "_ag_label_vertex", "properties": {"age": 36, "name": "Andres"}}::vertex, {"id": 1125899906842625, "label": "KNOWS", "end_id": 281474976710659, "start_id": 281474976710657, "properties": {}}::edge, {"id": 281474976710659, "label": "_ag_label_vertex", "properties": {"age": 55, "name": "Bossman"}}::vertex]::path
- [{"id": 281474976710660, "label": "_ag_label_vertex", "properties": {"age": 35, "name": "David"}}::vertex, {"id": 1125899906842628, "label": "KNOWS", "end_id": 281474976710657, "start_id": 281474976710660, "properties": {}}::edge, {"id": 281474976710657, "label": "_ag_label_vertex", "properties": {"age": 36, "name": "Andres"}}::vertex, {"id": 844424930131969, "label": "BLOCKS", "end_id": 281474976710658, "start_id": 281474976710657, "properties": {}}::edge, {"id": 281474976710658, "label": "_ag_label_vertex", "properties": {"age": 25, "name": "Caesar"}}::vertex]::path
-(6 rows)
-
+ERROR: match_vle_terminal_edge() argument 1 must be an agtype integer or a graphid
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] CapnSpek commented on issue #1062: Update all regression tests (label redesign)
Posted by "CapnSpek (via GitHub)" <gi...@apache.org>.
CapnSpek commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1650812731
Tests that may require code changes.
File - expr.out
Line 2340
```
SELECT * FROM cypher('expr', $$
MATCH ()-[e]-() RETURN id(e), start_id(e), startNode(e)
$$) AS (id agtype, start_id agtype, startNode agtype);
```
```
- id | start_id | startnode
-------------------+------------------+----------------------------------------------------------------------------------
- 1407374883553281 | 1125899906842626 | {"id": 1125899906842626, "label": "v1", "properties": {"id": "middle"}}::vertex
- 1407374883553281 | 1125899906842626 | {"id": 1125899906842626, "label": "v1", "properties": {"id": "middle"}}::vertex
- 1407374883553282 | 1125899906842625 | {"id": 1125899906842625, "label": "v1", "properties": {"id": "initial"}}::vertex
- 1407374883553282 | 1125899906842625 | {"id": 1125899906842625, "label": "v1", "properties": {"id": "initial"}}::vertex
-(4 rows)
-
+ERROR: graphid 4 does not exist
```
Line 2373
```
SELECT * FROM cypher('expr', $$
MATCH ()-[e]-() RETURN id(e), end_id(e), endNode(e)
$$) AS (id agtype, end_id agtype, endNode agtype);
```
```
- id | end_id | endnode
-------------------+------------------+---------------------------------------------------------------------------------
- 1407374883553281 | 1125899906842627 | {"id": 1125899906842627, "label": "v1", "properties": {"id": "end"}}::vertex
- 1407374883553281 | 1125899906842627 | {"id": 1125899906842627, "label": "v1", "properties": {"id": "end"}}::vertex
- 1407374883553282 | 1125899906842626 | {"id": 1125899906842626, "label": "v1", "properties": {"id": "middle"}}::vertex
- 1407374883553282 | 1125899906842626 | {"id": 1125899906842626, "label": "v1", "properties": {"id": "middle"}}::vertex
-(4 rows)
-
+ERROR: graphid 5 does not exist
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] rafsun42 commented on issue #1062: Update all regression tests (label redesign)
Posted by "rafsun42 (via GitHub)" <gi...@apache.org>.
rafsun42 commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1658843895
@CapnSpek
Is it possible to create a python script to verify the tests (at least to some degree)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] CapnSpek commented on issue #1062: Update all regression tests (label redesign)
Posted by "CapnSpek (via GitHub)" <gi...@apache.org>.
CapnSpek commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1660778877
SoI was thinking maybe we can go over the SQL file and for every create clause store the vertices and edges in a list with our own sequence ids.
Then we store the result of the regression tests in another file.
And go over that file verifying their IDs whenever they're matched.
If their IDs match the current sequence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] CapnSpek commented on issue #1062: Update all regression tests (label redesign)
Posted by "CapnSpek (via GitHub)" <gi...@apache.org>.
CapnSpek commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1658879906
@rafsun42 I'll look into it and get back to it by tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] rafsun42 commented on issue #1062: Update all regression tests (label redesign)
Posted by "rafsun42 (via GitHub)" <gi...@apache.org>.
rafsun42 commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1650243158
@CapnSpek Thanks for catching that. I will look into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] panosfol commented on issue #1062: Update all regression tests (label redesign)
Posted by "panosfol (via GitHub)" <gi...@apache.org>.
panosfol commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1642966183
Assign me please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] CapnSpek commented on issue #1062: Update all regression tests (label redesign)
Posted by "CapnSpek (via GitHub)" <gi...@apache.org>.
CapnSpek commented on issue #1062:
URL: https://github.com/apache/age/issues/1062#issuecomment-1657308513
I have updated cypher_delete and index regression tests to work now as per the new design.
I have also fixed cypher_match as @rafsun42 had said. All the errors are still there but the id issues are fixed.
I have created a PR for the same https://github.com/rafsun42/age/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org