[GitHub] [hive] nrg4878 commented on pull request #2869: Hive 25795: Update log4j2 version to 2.16.0 for branch-3 (Naveen Gangam)

[GitBox <gi...@apache.org>]

nrg4878 commented on pull request #2869:
URL: https://github.com/apache/hive/pull/2869#issuecomment-996146648


   > It still seems to depend on log4j 2.6.2 in hive-upgrade-acid module.
   > 
   > ```
   > [INFO] org.apache.hive:hive-upgrade-acid:jar:3.2.0-SNAPSHOT
   > ...
   > [INFO] +- org.apache.hive:hive-exec:jar:2.3.3:provided
   > ...
   > [INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.6.2:provided
   > [INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.6.2:provided
   > [INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.6.2:provided
   > ```
   > 
   > I think it should be excluded in `upgrade-acid/pom.xml`.
   > 
   > ```diff
   >         <dependency>
   >             <groupId>org.apache.hive</groupId>
   >             <artifactId>hive-metastore</artifactId>
   >             <version>2.3.3</version>
   >             <scope>provided</scope>
   > +            <exclusions>
   > +                <exclusion>
   > +                    <groupId>org.apache.logging.log4j</groupId>
   > +                    <artifactId>log4j-core</artifactId>
   > +                </exclusion>
   > +            </exclusions>
   >         </dependency>
   >         <dependency>
   >             <groupId>org.apache.hive</groupId>
   >             <artifactId>hive-exec</artifactId>
   >             <version>2.3.3</version>
   >             <scope>provided</scope>
   > +            <exclusions>
   > +                <exclusion>
   > +                    <groupId>org.apache.logging.log4j</groupId>
   > +                    <artifactId>log4j-core</artifactId>
   > +                </exclusion>
   > +            </exclusions>
   >         </dependency>
   > ```
   
   Thanks @tasanuma for the review. Looks like the scoping for this transitive dependency is "provided" which means it expects the jar to be added by the user. It should not automatically include in the distribution. Is that still a concern?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org