You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by 24601 <gi...@git.apache.org> on 2014/07/16 22:48:34 UTC
[GitHub] spark pull request: Added t2 instance types
GitHub user 24601 opened a pull request:
https://github.com/apache/spark/pull/1446
Added t2 instance types
New t2 instance types require HVM amis, bailout assumption of pvm
causes failures when using t2 instance types.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/24601/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1446.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1446
----
commit 392a95ef97d9644b52d7526a1a068b6d9dbf01c0
Author: Basit Mustafa <ba...@computes-things-for-basit.local>
Date: 2014-07-16T20:45:37Z
Added t2 instance types
New t2 instance types require HVM amis, bailout assumption of pvm
causes failures when using t2 instance types.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Added t2 instance types
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1446#issuecomment-49225163
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Added t2 instance types
Posted by aarondav <gi...@git.apache.org>.
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/1446#issuecomment-49250359
Adding the commit to the branch made it already update this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Added t2 instance types
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1446#issuecomment-49469831
LGTM - thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Added t2 instance types
Posted by 24601 <gi...@git.apache.org>.
Github user 24601 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1446#discussion_r15038068
--- Diff: ec2/spark_ec2.py ---
@@ -240,7 +240,10 @@ def get_spark_ami(opts):
"r3.xlarge": "hvm",
"r3.2xlarge": "hvm",
"r3.4xlarge": "hvm",
- "r3.8xlarge": "hvm"
+ "r3.8xlarge": "hvm",
+ "t2.micro": "hvm",
+ "t2.small":"hvm",
+ "t2.medium":"hvm"
--- End diff --
Sure, commit https://github.com/24601/spark/commit/01fe1288c85674fc2d03ee4896e00aae182f4829 does this, I can submit another PR against that commit if needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Added t2 instance types
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1446
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Added t2 instance types
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1446#discussion_r15027927
--- Diff: ec2/spark_ec2.py ---
@@ -240,7 +240,10 @@ def get_spark_ami(opts):
"r3.xlarge": "hvm",
"r3.2xlarge": "hvm",
"r3.4xlarge": "hvm",
- "r3.8xlarge": "hvm"
+ "r3.8xlarge": "hvm",
+ "t2.micro": "hvm",
+ "t2.small":"hvm",
+ "t2.medium":"hvm"
--- End diff --
Ca you format these correctly with the other ones?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---