You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2023/01/03 21:24:16 UTC

[GitHub] [pinot] egalpin commented on a diff in pull request #10000: [Issue 7519] Adds support for multiple filtered/unfiltered aggregations with GROUP BY

egalpin commented on code in PR #10000:
URL: https://github.com/apache/pinot/pull/10000#discussion_r1060966982


##########
pinot-core/src/test/java/org/apache/pinot/core/query/aggregation/groupby/GroupByTrimTest.java:
##########
@@ -130,7 +129,7 @@ void testGroupByTrim(QueryContext queryContext, int minSegmentGroupTrimSize, int
     // Extract the execution result
     List<Pair<Double, Double>> extractedResult = extractTestResult(resultsBlock.getTable());
 
-    assertEquals(extractedResult, expectedResult);
+    Assert.assertEquals(extractedResult, expectedResult);

Review Comment:
   I had changed this due to checkstyle violations:
   
   ```[WARNING] (imports) AvoidStaticImport: Using a static member import should be avoided```
   
   I can revert back so long as checkstyle still passes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org