You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/14 02:18:26 UTC

[GitHub] [apisix] spacewander commented on a change in pull request #3032: Add apisix configmaps yaml file.

spacewander commented on a change in pull request #3032:
URL: https://github.com/apache/apisix/pull/3032#discussion_r542067516



##########
File path: kubernetes/README.md
##########
@@ -30,6 +30,8 @@ There are some yaml files for deploying apisix in Kubernetes.
 if you do not need to change any config, and use default config in `../conf/config.yaml`
 ```
 $ kubectl create configmap apisix-gw-config.yaml --from-file=../conf/config.yaml
+# or
+$ kubectl apply -f apisix/kubernetes/apisix-configmaps.yaml

Review comment:
       If we can create apisix-configmaps.yaml from `conf/config.yaml`, why do we need to maintain another copy of `conf/config.yaml`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org