You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/09 12:38:37 UTC

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6919: Minor console access refactor and improvements

weizhouapache commented on code in PR #6919:
URL: https://github.com/apache/cloudstack/pull/6919#discussion_r1044414857


##########
server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java:
##########
@@ -489,6 +494,6 @@ public String getConfigComponentName() {
 
     @Override
     public ConfigKey<?>[] getConfigKeys() {
-        return new ConfigKey[] { ConsoleProxyExtraSecurityValidationEnabled };
+        return new ConfigKey[] { };

Review Comment:
   if so, we can remove `Configurable` from ConsoleAccessManager



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org